Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feko read #1328

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add feko read #1328

wants to merge 12 commits into from

Conversation

nmahesh1412
Copy link

Description

added a feko_beam.py to read in feko .ffe files

Motivation and Context

adds the capability of reading in aFEKO simulation file

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

Bug fix checklist:

  • My fix includes a new test that breaks as a result of the bug (if possible).
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

New feature checklist:

  • I have added or updated the docstrings associated with my feature using the numpy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate).
  • I have added tests to cover my new feature.
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

Breaking change checklist:

  • I have updated the docstrings associated with my change using the numpy docstring format.
  • I have updated the tutorial to reflect my changes (if appropriate).
  • My change includes backwards compatibility and deprecation warnings (if possible).
  • I have added tests to cover my changes.
  • All new and existing tests pass.
  • I have updated the CHANGELOG.

Documentation change checklist:

  • Any updated docstrings use the numpy docstring format.
  • If this is a significant change to the readme or other docs, I have checked that they are rendered properly on ReadTheDocs. (you may need help to get this branch to build on RTD, just ask!)

Version change checklist:

  • I have updated the CHANGELOG to put all the unreleased changes under the new version (leaving the unreleased section empty).
  • I have noted any dependency changes since the last version and will update the conda package build accordingly.

Build or continuous integration change checklist:

  • If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
  • If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1328 (5ca0937) into main (b75d028) will decrease coverage by 1.38%.
The diff coverage is 0.70%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1328      +/-   ##
==========================================
- Coverage   99.92%   98.55%   -1.38%     
==========================================
  Files          36       37       +1     
  Lines       20202    20485     +283     
==========================================
+ Hits        20186    20188       +2     
- Misses         16      297     +281     
Files Coverage Δ
pyuvdata/uvbeam/uvbeam.py 92.41% <1.49%> (-7.59%) ⬇️
pyuvdata/uvbeam/feko_beam.py 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b75d028...5ca0937. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants