1492 window ventilation #1495
Open
1492 window ventilation #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jun Jiang <jun.jiang@eonerc.rwth-aachen.de>
Signed-off-by: Jun Jiang <jun.jiang@eonerc.rwth-aachen.de>
Signed-off-by: Jun Jiang <jun.jiang@eonerc.rwth-aachen.de>
Signed-off-by: Jun Jiang <jun.jiang@eonerc.rwth-aachen.de>
Signed-off-by: Jun Jiang <jun.jiang@eonerc.rwth-aachen.de>
Signed-off-by: Jun Jiang <jun.jiang@eonerc.rwth-aachen.de>
Signed-off-by: Jun Jiang <jun.jiang@eonerc.rwth-aachen.de>
Signed-off-by: Jun Jiang <jun.jiang@eonerc.rwth-aachen.de>
Signed-off-by: Jun Jiang <jun.jiang@eonerc.rwth-aachen.de>
Signed-off-by: Jun Jiang <jun.jiang@eonerc.rwth-aachen.de>
Signed-off-by: Jun Jiang <jun.jiang@eonerc.rwth-aachen.de>
Signed-off-by: Jun Jiang <jun.jiang@eonerc.rwth-aachen.de>
|
@Jun-Jiang-92 Thanks for the big new package! I would suggest to split up the review, so that others get customed to review, as well. @MZuschlag, are you interested in the review of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the package "WindowVentilation" under "AixLib.Airflow". This package provides several empirical expressions based on the literature to estimate the air volume flow by single-sided window opening.
Link to issue #1492.