Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1367 geothermalheatpump example fails in openmodelica #1441

Merged
merged 14 commits into from
Jul 17, 2023
Merged

1367 geothermalheatpump example fails in openmodelica #1441

merged 14 commits into from
Jul 17, 2023

Conversation

HannahRomberg
Copy link
Contributor

Closes #1367

The flow direction from the cold storage to the evaporator was going in the wrong direction. The heating coil orientation was changed to down->up and the port connections were changed to allow the flow in the right direction.

@HannahRomberg HannahRomberg linked an issue Jun 6, 2023 that may be closed by this pull request
GeothermalHeatPump example fails in OpenModelica #1367
Closed
FWuellhorst
FWuellhorst requested changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the name and check if the new connection is required. If the line is better now, you can leave it.

AixLib/Fluid/Examples/GeothermalHeatPump/BaseClasses/GeothermalHeatPumpBase.mo Show resolved Hide resolved
AixLib/Fluid/Examples/GeothermalHeatPump/BaseClasses/GeothermalHeatPumpBase.mo Outdated Show resolved Hide resolved
@ebc-aixlib-bot
Copy link
Contributor

Errors in regression test. Compare the results on the following page
https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/1367-geothermalheatpump-example-fails-in-openmodelica/plots

@DaJansenGit
Copy link
Member

The previous pipelines failed due to another, not already solved, problem with the AixLib.Controls.HVACAgentBasedControl package. For now, I put the models on the whitelist and opened issue #1447 which needs to be solved independent from this pull request.

@DaJansenGit DaJansenGit mentioned this pull request Jul 12, 2023
Open
HannahRomberg
HannahRomberg commented Jul 17, 2023
View reviewed changes
Copy link
Contributor Author

@HannahRomberg HannahRomberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adressed requested changes. See comments.

FWuellhorst
FWuellhorst approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@HannahRomberg HannahRomberg merged commit 1669119 into development Jul 17, 2023
1 check passed
@HannahRomberg HannahRomberg deleted the 1367-geothermalheatpump-example-fails-in-openmodelica branch July 17, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FWuellhorst FWuellhorst FWuellhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GeothermalHeatPump example fails in OpenModelica
5 participants
@HannahRomberg @ebc-aixlib-bot @DaJansenGit @FWuellhorst @larissakuehn