Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples for StorageDetailed and StorageSimple models #1223

Open
3 tasks done
LauraMaier opened this issue Jan 27, 2022 · 1 comment · May be fixed by #1307
Open
3 tasks done

Add examples for StorageDetailed and StorageSimple models #1223

LauraMaier opened this issue Jan 27, 2022 · 1 comment · May be fixed by #1307
Assignees
@LauraMaier
Projects
Hackday_07_22

Comments

@LauraMaier
Copy link
Contributor

LauraMaier commented Jan 27, 2022 •
edited

In issue #1171 the former storages were renamed to StorageDetailed and StorageSimple.
Yet, beforehand, in all storage example the storage was replaced by the StorageDetailed model.
Consequently, there is no example for the StorageSimple model at the moment.

How do I intend to solve the issue?

  • Recheck existing example models for StorageDetailed and select suitable ones for StorageSimple
  • Implement similar example models in accordance with the selected StorageDetails examples
  • Possibly add further examples if needed to enhance comprehensibility
@LauraMaier LauraMaier self-assigned this Jan 27, 2022
@tobinfiedler tobinfiedler added this to todo in Hackday_07_22 Jul 13, 2022
@LauraMaier LauraMaier moved this from todo to doing in Hackday_07_22 Jul 14, 2022
LauraMaier added a commit that referenced this issue Jul 14, 2022
@LauraMaier
Merge branch 'issue1171_StorageSpringCleaning' into issue1223_NewStor…
4f46a9a 
…ageExamples #1223
LauraMaier added a commit that referenced this issue Jul 14, 2022
@LauraMaier
Add example for simple storage #1223
9d0a6d3
@LauraMaier LauraMaier linked a pull request Jul 14, 2022 that will close this issue
Open
@tobinfiedler tobinfiedler moved this from doing to Review/Pipline in Hackday_07_22 Jul 14, 2022
LauraMaier added a commit that referenced this issue Jul 14, 2022
@LauraMaier
Adapt specific heat capacity #1223 [skip ci]
c2f454b
LauraMaier added a commit that referenced this issue Jul 14, 2022
@LauraMaier
Add simulate and plot script #1223 [skip ci]
ea1f35f
LauraMaier added a commit that referenced this issue Jul 14, 2022
@LauraMaier
Add pressure drops #1223
3adddb2
LauraMaier added a commit that referenced this issue Oct 12, 2022
@LauraMaier
Change all paths to absolute paths and replace PID controller #1223 […
c5cc586 
…skip ci]
LauraMaier added a commit that referenced this issue Oct 12, 2022
@LauraMaier
Corrected some absolute paths #1223 [skip ci]
e019b52
LauraMaier added a commit that referenced this issue Oct 12, 2022
@LauraMaier
Replaced PIDs by AL models rather than MSL #1223 [skip ci]
8cea333
LauraMaier added a commit that referenced this issue Oct 12, 2022
@LauraMaier
Refactoring and adding descriptions #1223
1ebf6e3
LauraMaier added a commit that referenced this issue Oct 13, 2022
@LauraMaier
Replace wrong storage path in exergy example #1223
f279c80
LauraMaier added a commit that referenced this issue Oct 14, 2022
@LauraMaier
Correct simulate and plot script and update ref results "ci_update_ref"
f278ae2 
#1223
LauraMaier added a commit that referenced this issue Oct 17, 2022
@LauraMaier
Sloppy change to trigger CI with new reference results "ci_update_ref" …
20d3cfb 
…#1223
LauraMaier added a commit that referenced this issue Oct 21, 2022
@LauraMaier
Delete ref results to force CI to create new ones #1223
e597844
LauraMaier added a commit that referenced this issue Oct 24, 2022
@LauraMaier
Adapt initialization #1223
38b4e76
LauraMaier added a commit that referenced this issue Oct 24, 2022
@LauraMaier
Trigger update of reference results for solar collector example #1223
ba57c81
LauraMaier added a commit that referenced this issue Oct 24, 2022
@LauraMaier
Adapt simulate and plot script, delete ref results and add initializa…
0e72f33 
…tion info #1223
LauraMaier added a commit that referenced this issue Oct 28, 2022
@LauraMaier
Refactor paths and delete import SI #1223
df1739e
LauraMaier added a commit that referenced this issue Nov 14, 2022
@LauraMaier
Add full paths #1223
7b39720
LauraMaier added a commit that referenced this issue Nov 14, 2022
@LauraMaier
Delete unnecessary import AixLib commands #1223
958a197
LauraMaier added a commit that referenced this issue Nov 14, 2022
@LauraMaier
Restructure model and delete faulty assignments in documentation #1223
9a5ed2d
LauraMaier added a commit that referenced this issue Nov 14, 2022
@LauraMaier
Adapt faulty reference #1223
03173f1
LauraMaier added a commit that referenced this issue Nov 14, 2022
@LauraMaier
Add array for output of temperatures for each layer #1223
d64920a
LauraMaier added a commit that referenced this issue Nov 14, 2022
@LauraMaier
Add revisions in docu and update simulate and plot script #1223
44b9501
LauraMaier added a commit that referenced this issue Nov 14, 2022
@LauraMaier
Adapt simulate and plot scripts and update ref results #1223
5e60ccf
LauraMaier added a commit that referenced this issue Nov 14, 2022
@LauraMaier
Add documentation for storage boiler example #1223
0e9d003
LauraMaier added a commit that referenced this issue Nov 14, 2022
@LauraMaier
Add revision section and further documentation #1223
382f0b0
LauraMaier added a commit that referenced this issue Nov 14, 2022
@LauraMaier
Update simulate and plot script #1223
4d5d235
LauraMaier added a commit that referenced this issue Nov 17, 2022
@LauraMaier
Delete import SI and update documentation #1223
51c03d7
LauraMaier added a commit that referenced this issue Nov 17, 2022
@LauraMaier
Adapt html for revisions and delete overview section #1223
e253d18
LauraMaier added a commit that referenced this issue Nov 17, 2022
@LauraMaier
delete ugly white space #1223
868b3df
LauraMaier added a commit that referenced this issue Nov 17, 2022
@LauraMaier
Reformatting of ugly white spaces #1223
c7459e1
LauraMaier added a commit that referenced this issue Nov 17, 2022
@LauraMaier
More ugly white spaces #1223
dc8a752
LauraMaier added a commit that referenced this issue Nov 17, 2022
@LauraMaier
More and more ugly white spaces #1223
f432824
LauraMaier added a commit that referenced this issue Nov 17, 2022
@LauraMaier
Revert unintended change in reference results #1223
21eeeee
LauraMaier added a commit that referenced this issue Nov 17, 2022
@LauraMaier
Revert unintented change in ref results of thermal zone #1223
4dc0c4c
LauraMaier added a commit that referenced this issue Nov 17, 2022
@LauraMaier
Revert unintended change in ref results #1223
47f63a4
LauraMaier added a commit that referenced this issue Nov 17, 2022
@LauraMaier
Revert unintended changes in .mos script and update ref results #1223
6faa28d
LauraMaier added a commit that referenced this issue Nov 21, 2022
@LauraMaier
Correct html manually #1223
e4420a2
LauraMaier added a commit that referenced this issue Nov 21, 2022
@LauraMaier
Correct html manually #1223
00fe3e7
LauraMaier added a commit that referenced this issue Nov 21, 2022
@LauraMaier
Correct more html manually #1223
951fd78
LauraMaier added a commit that referenced this issue Nov 22, 2022
@LauraMaier
Correct html manually #1223
8ad40b2
@FelixStege
Copy link
Contributor

@LauraMaier, this seems like a good Issue for the upcoming hackday?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LauraMaier LauraMaier

Labels
None yet
Projects
No open projects
Hackday_07_22
Review/Pipline
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue1223 new storage examples RWTH-EBC/AixLib
2 participants
@LauraMaier @FelixStege