Don't try to close the dome if already closed after bad weather #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkubanek
requested changes
Apr 1, 2024
According to isClosed docs: "It is called also outside of the closing sequence, to check if dome is closed when bad weather arrives." Right now, I get a lot of "closeDomeWeather: domeCloseStart" spam in the logs when it's daytime and the weather station reports bad weather. This commit avoids all that spam and will only log if it's not closed.
Sure, it's done. |
pkubanek
approved these changes
Apr 1, 2024
|
Sure, I'll double-check. About merging: I don't think I can do that. |
|
Double-checked. This is ready for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to isClosed docs:
Right now, I get a lot of "closeDomeWeather: domeCloseStart" spam in the logs when it's daytime and the weather station reports bad weather.
This commit avoids all that spam and will only log (and try to close the dome) if it's not closed.