Skip to content

Commit

Permalink
Don't use --profiling for benchmarks
Browse files Browse the repository at this point in the history
This leads to incorrect size comparison as it includes function name sizes.
  • Loading branch information
RReverser committed Dec 9, 2023
1 parent 3dfe727 commit b4b4965
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions benchmarks/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
"pretty-bytes": "^6.0.0"
},
"scripts": {
"build:swb": "wasm-pack build -t nodejs --profiling --out-dir pkg/serde-wasm-bindgen -- --features serde-wasm-bindgen",
"build:swb-reftypes": "cross-env RUSTFLAGS=\"-C target-feature=+reference-types\" WASM_BINDGEN_EXTERNREF=1 wasm-pack build -t nodejs --profiling --out-dir pkg/serde-wasm-bindgen-reftypes -- --features serde-wasm-bindgen",
"build:json": "wasm-pack build -t nodejs --profiling --out-dir pkg/serde-json -- --features serde-json",
"build:msgpack": "wasm-pack build -t nodejs --profiling --out-dir pkg/msgpack -- --features msgpack",
"build:swb": "wasm-pack build -t nodejs --out-dir pkg/serde-wasm-bindgen -- --features serde-wasm-bindgen",
"build:swb-reftypes": "cross-env RUSTFLAGS=\"-C target-feature=+reference-types\" WASM_BINDGEN_EXTERNREF=1 wasm-pack build -t nodejs --out-dir pkg/serde-wasm-bindgen-reftypes -- --features serde-wasm-bindgen",
"build:json": "wasm-pack build -t nodejs --out-dir pkg/serde-json -- --features serde-json",
"build:msgpack": "wasm-pack build -t nodejs --out-dir pkg/msgpack -- --features msgpack",
"build": "npm run build:swb && npm run build:json",
"test": "node index.mjs"
}
Expand Down

0 comments on commit b4b4965

Please sign in to comment.