Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlays/input: allow ldd pad input #15180

Merged
merged 2 commits into from May 18, 2024
Merged

overlays/input: allow ldd pad input #15180

merged 2 commits into from May 18, 2024

Conversation

Megamouse
Copy link
Contributor

  • Query LDD pad data in the overlay input loop

We usually only care for the rpcs3 input wrapper when we handle input in the overlays.
But LDD pads are basically extra pads registered by the game (like a custom controller or some instrument).
The input state of these LDD pads is populated by the game itself instead of us.
So in order to receive input of these pads in the overlays, we have to manually check the proper ldd_data buffer.

probably fixes #15164

@DarkRTA
Copy link
Contributor

DarkRTA commented Feb 12, 2024

After testing this I can confirm that the issue is not fixed.

@carlmylo
Copy link

carlmylo commented Feb 12, 2024

Tested on Windows with:

  • RB3 PS3 Mustang PRO Guitar connected via MIDI to USB and set up via the I/O tab in Custom Configuration = Native Interface didn't respond, game responded
  • RB3 PS3 Mustang PRO Guitar connected via Zadig/Passthrough = Native Interface didn't respond, game responded
  • RB3 PS3 Wireless PRO Keyboard connected via Zadig/Passthrough (Linos tested this one) = Native Interface didn't respond, game responded
  • Generic MIDI Keyboard connected via USB and set up via the I/O tab in Custom Configuration = Native Interface didn't respond, game responded
  • Wii Rock Band Hofner Guitar Controller set up via Gamepad Configuration (MMJoystick) = Native Interface and game responded correctly. PS Guide button assignment also worked.

Logs if needed: Rock Band 3 [BLUS30463].log.gz

@Florin9doi
Copy link
Contributor

Florin9doi commented May 18, 2024

I don't have instruments, but uDraw navigation is fixed by this PR together with #15606

@Megamouse Megamouse marked this pull request as ready for review May 18, 2024 09:14
@Megamouse Megamouse merged commit aff2588 into RPCS3:master May 18, 2024
6 checks passed
@Megamouse Megamouse deleted the ldd branch May 18, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instruments do not pass button presses to Native Interface
4 participants