RPP Glitch on HOST and HIP #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
r-abishek
commented
May 17, 2024
r-abishek
commented
- Adds support for glitch augmentation on host and hip
- Adds relevant unit/performance/QA tests
…itch augmentation
…ripts for glitch augmentation
…litch augmentation
added golden output support for glitch
… for performance tests
* add NFT and NTF layouts * Set layout for spectrogram and melfilterbank directly in testsuite * Remove extra blank line in testsuite * minor changes in test suite * minor change in MFB description --------- Co-authored-by: Snehaa Giridharan <snehaa@multicorewareinc.com> Co-authored-by: sampath1117 <sampath.rachumallu@multicorewareinc.com>
cleanup the code
RPP Glitch Tensor on HOST and HIP
rrawther
reviewed
Jun 3, 2024
| inline void compute_src_loc(int row , int col, Rpp32s *locArray, RpptDescPtr srcDescPtr, RpptChannelOffsets *rgbOffsets, RpptROI roi, int batchCount, int channelValue) | ||
| { | ||
| int xR, yR, xG, yG, xB, yB; | ||
| xR = col + rgbOffsets[batchCount].r.x; |
There was a problem hiding this comment.
can we make sure the rgbOffsets[]... are within valid boundary thereby avoiding the boundary checks below
There was a problem hiding this comment.
Discussed this, and the only solution here without checking bounds might be to just trust the user/caller that they will give the values within bounds, which may not necessarily be true.
Agreed to have the checks on the hip side at least for now.
rrawther
reviewed
Jun 3, 2024
src/modules/cpu/kernel/glitch.hpp
Outdated
| Rpp32f *dstPtrRow; | ||
| dstPtrRow = dstPtrChannel; | ||
| Rpp32u vectorIncrement = 8; | ||
| Rpp32u alignedLength = (static_cast<int>(roi.xywhROI.roiWidth * 0.75)) & ~7; // Considering 75% of the ROI width to avoid loading out-of-bounds locations. |
There was a problem hiding this comment.
as we discussed, this can cause some areas visibily showing without glitching. why don't we make it truncated to the nearest multiple of 16 for alignment as well
There was a problem hiding this comment.
Done, removed the 0.75, changed to nearest multiple of alignedLength
RPP Glitch - Modified Aligned Length computation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.