Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPP Erase on HOST and HIP #336

Merged
merged 97 commits into from
Jun 5, 2024
Merged

RPP Erase on HOST and HIP #336

merged 97 commits into from
Jun 5, 2024

Conversation

r-abishek
Copy link
Member

  • Adds Erase support for HOST and HIP
  • Adds relevant unit/perf/QA tests

sampath1117 and others added 30 commits January 18, 2024 17:42
@sampath1117
experimental changes for adding qa mode for performance tests
dcd54ac
@sampath1117
made changes to add display more information w.r.t QA results summary…
50138ea 
… for performance tests
@sampath1117
minor changes
f3bea0e
@HazarathKumarM
Add changes to dump qa results to excel file
58a915a
@HazarathKumarM
Add performance QA for three new tensor functions
03c5d27
@HazarathKumarM
update prerequisites in readme
a5d49a0
@HazarathKumarM
merged latest changes
2e0f922
@sampath1117
added changes to handle unsupported cases
c097f74
@HazarathKumarM
removed treshold dictionary and added performance Noise treshold
ba860e4 
add new dataset for performance QA
@r-abishek @HazarathKumarM
RPP Test Suite Upgrade 4 - CSV to BIN conversions for file size reduc…
a7f17f7 
…tion (ROCm#293)

* change golden outputs from .csv files to .bin files

* Changed comparision funtions to use .bin files

* Address review comments

* minor change

* Address review comments

* minor change

---------

Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
@snehaa8
Merge remote-tracking branch 'TOT/develop' into sr/qa_perf
f6ee505
@r-abishek
Merge pull request #221 from sampath1117/sr/qa_perf
b9c8cdc 
Test suite support for doing QA w.r.t performance
@HazarathKumarM
Changes to the performane summary dataframe
fa0e3ab
@HazarathKumarM
Merge branch 'sr/qa_perf' of https://github.com/sampath1117/rpp into …
35f26f0 
…sr/qa_perf
@HazarathKumarM
minor changes
067d575
@r-abishek
Update CMakeLists.txt to add ${CMAKE_CURRENT_SOURCE_DIR} for CI
8ed21ae
@r-abishek
Update CMakeLists.txt fix
1cdfcde
@r-abishek
Update CMakeLists.txt fix
f82145e
@HazarathKumarM
remove tabulate dependency
0c4f413
@r-abishek
Merge pull request #229 from sampath1117/sr/qa_perf
407360d 
Rpp Performance Test Suite
@r-abishek
Update README.md to remove tabulate pip install
511a7af
@r-abishek @kiritigowda
License - updates to 2024 and consistency changes (ROCm#298)
a1f4213 
* Match all CMakeLists.txt license as per RPP's outermost LICENSE file

* Match all python files' license as per RPP's outermost LICENSE file

* Match all .hpp files' license as per RPP's outermost LICENSE file

* Match all .cpp files' license as per RPP's outermost LICENSE file

* Match all .h files' license as per RPP's outermost LICENSE file

* Remove all rights reserved as per LICENSE file

* Remove double space in "Copyright (c) 2019 - 2023 Advanced Micro Devices, Inc."

* Match all .cmake files' license as per RPP's outermost LICENSE file

* Match all .cpp.in files' license as per RPP's outermost LICENSE file

* Replace 283 occurrences in 282 files - 2023 to 2024

* Add "MIT License" title to 281 instances

* Add missing license
@r-abishek @kiritigowda
Test - Update README.md for test_suite (ROCm#299)
7096c1d
@r-abishek
Merge branch 'master' of https://github.com/GPUOpen-ProfessionalCompu…
dab18e0 
…te-Libraries/rpp into ar/test_suite_upgrade_5_qa_perf
@dependabot
Bump rocm-docs-core[api_reference] from 0.33.0 to 0.33.1 in /docs/sph…
07a5f66 
…inx (ROCm#301)

Bumps [rocm-docs-core[api_reference]](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.33.0 to 0.33.1.
- [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v0.33.0...v0.33.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump rocm-docs-core[api_reference] from 0.33.1 to 0.33.2 in /docs/sph…
a5e5679 
…inx (ROCm#302)

Bumps [rocm-docs-core[api_reference]](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.33.1 to 0.33.2.
- [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v0.33.1...v0.33.2)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@r-abishek
Fix for CI machine failure
37186bb
@r-abishek
Add note on performance
b889a79
@samjwu
Update doc codeowners (ROCm#303)
e8aa6b2
@paveltc
Merge pull request ROCm#297 from r-abishek/ar/test_suite_upgrade_5_qa…
5787417 
…_perf

RPP Test Suite Upgrade 5 - Support for default QA perf testing and Tensor/BatchPD compares
@r-abishek
Merge pull request #274 from sampath1117/sr/erase
7400aa2 
Erase - Fix F32 outputs and Address review comments
@r-abishek
formatting fix
eda8207
@kiritigowda kiritigowda changed the base branch from develop to master May 24, 2024 06:37
@kiritigowda kiritigowda requested a review from a team as a code owner May 24, 2024 06:37
@kiritigowda kiritigowda changed the base branch from master to develop May 24, 2024 06:44
@kiritigowda kiritigowda marked this pull request as draft May 24, 2024 08:05
rrawther
rrawther requested changes May 26, 2024
View reviewed changes
Copy link
Contributor

@rrawther rrawther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some comments. Not sure why this is so huge (84 file changes).
We have decided to smaller PRs and not having to change so many files

@r-abishek
Copy link
Member Author

@rrawther The erase PR has changes only for erase functionality.
develop got merged into master over the long weekend.
Merge conflicts are resolved now and the correct diff will show with 14 files changed.

@r-abishek r-abishek marked this pull request as ready for review May 29, 2024 02:42
@rrawther
Copy link
Contributor

@AryanSalmanpour : please review the HIP kernels related to erase

rrawther
rrawther requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@rrawther rrawther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address review comments

@kiritigowda kiritigowda merged commit 612d74e into ROCm:develop Jun 5, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrawther rrawther rrawther approved these changes

@AryanSalmanpour AryanSalmanpour AryanSalmanpour approved these changes

@LakshmiKumar23 LakshmiKumar23 Awaiting requested review from LakshmiKumar23

Assignees

@kiritigowda kiritigowda

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet