Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed NULL check #492

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Fixed NULL check #492

wants to merge 5 commits into from
+26 −10

Conversation

rponnuru5
Copy link

@rponnuru5 rponnuru5 commented May 14, 2024 •
edited

Added a test case to check for NULL for rocrond_generate_long_long and rocrand_geenrate_char

@rponnuru5 @Naraenda
Committed the suggestion for null pointer
857d7f9 
Co-authored-by: Nara <naraenda@prasetya.eu>
@Naraenda
Copy link
Member

I meant replacing all the NULL with nullptr in the proposed change, not just that single one 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naraenda Naraenda Naraenda left review comments

@stanleytsang-amd stanleytsang-amd Awaiting requested review from stanleytsang-amd stanleytsang-amd is a code owner

@umfranzw umfranzw Awaiting requested review from umfranzw umfranzw is a code owner

@RobsonRLemos RobsonRLemos Awaiting requested review from RobsonRLemos RobsonRLemos is a code owner

@lawruble13 lawruble13 Awaiting requested review from lawruble13 lawruble13 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci:codecoverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rponnuru5 @Naraenda @samjwu @NguyenNhuDi