Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RPATH/RUNPATH from ROCm libraries and binaries #301

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Remove RPATH/RUNPATH from ROCm libraries and binaries #301

wants to merge 2 commits into from
+4 −9

Conversation

raramakr
Copy link

SWDEV-310152:

  • Single version package: add ldconfig, no RPATH/RUNPATH in either binaries or libraries
  • Multi version package: use RPATH for binaries, no RPATH/RUNPATH for libraries
  • amdclang/clang/hipcc compilers shall not add RPATH/RUNPATH to produced binaries or libraries unless explicitly requested by an option
  • Versioning scripts will take care of adding rpath to binaries for multi version package

@raramakr
Remove rpath/runpath from ROCm binaries and libraries
17c96fb 
SWDEV-310152:
- Single version package: add ldconfig, no RPATH/RUNPATH in either binaries or libraries
- Multi version package: use RPATH for binaries, no RPATH/RUNPATH for libraries
- amdclang/clang/hipcc compilers shall not add RPATH/RUNPATH to produced binaries or libraries unless explicitly
requested by an option
- Versioning scripts will take care of adding rpath to binaries for multi version package
@raramakr
Do not add paths to linker search and installed rpath.
f9f27f8
@raramakr raramakr marked this pull request as draft December 9, 2022 20:42
@codecov
Copy link

codecov bot commented Feb 6, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (develop@0303db7). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head defdd0c differs from pull request most recent head f9f27f8. Consider uploading reports for the commit f9f27f8 to get more accurate results

@@            Coverage Diff             @@
##             develop     #301   +/-   ##
==========================================
  Coverage           ?   58.05%           
==========================================
  Files              ?       51           
  Lines              ?     4815           
  Branches           ?        0           
==========================================
  Hits               ?     2795           
  Misses             ?     2020           
  Partials           ?        0
Flag Coverage Δ
gfx906 58.05% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Naraenda pushed a commit to StreamHPC/rocRAND that referenced this pull request Nov 15, 2023
@mfep @Naraenda
Merge branch 'dynamic-ordering' into 'develop_stream'
d6cc4b7 
Dynamic config dispatch for most generators

Closes ROCm#297, ROCm#298, ROCm#299, ROCm#300, ROCm#301, and ROCm#303

See merge request amd/libraries/rocRAND!268
neon60 pushed a commit that referenced this pull request Jan 10, 2024
@mfep
Merge branch 'dynamic-ordering' into 'develop_stream'
1eda3f7 
Dynamic config dispatch for most generators

Closes #297, #298, #299, #300, #301, and #303

See merge request amd/libraries/rocRAND!268
Naraenda pushed a commit to StreamHPC/rocRAND that referenced this pull request Jan 16, 2024
@mfep @Maetveis
Merge branch 'dynamic-ordering' into 'develop_stream'
24bed1e 
Dynamic config dispatch for most generators

Closes ROCm#297, ROCm#298, ROCm#299, ROCm#300, ROCm#301, and ROCm#303

See merge request amd/libraries/rocRAND!268
mfep added a commit to StreamHPC/rocRAND that referenced this pull request Jan 23, 2024
@mfep
Merge branch 'dynamic-ordering' into 'develop_stream'
e7da66d 
Dynamic config dispatch for most generators

Closes ROCm#297, ROCm#298, ROCm#299, ROCm#300, ROCm#301, and ROCm#303

See merge request amd/libraries/rocRAND!268
mfep added a commit to StreamHPC/rocRAND that referenced this pull request Feb 19, 2024
@mfep
Merge branch 'dynamic-ordering' into 'develop_stream'
f7d35b3 
Dynamic config dispatch for most generators

Closes ROCm#297, ROCm#298, ROCm#299, ROCm#300, ROCm#301, and ROCm#303

See merge request amd/libraries/rocRAND!268
mfep added a commit to StreamHPC/rocRAND that referenced this pull request Feb 23, 2024
@mfep
Merge branch 'dynamic-ordering' into 'develop_stream'
d54e093 
Dynamic config dispatch for most generators

Closes ROCm#297, ROCm#298, ROCm#299, ROCm#300, ROCm#301, and ROCm#303

See merge request amd/libraries/rocRAND!268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saadrahim saadrahim Awaiting requested review from saadrahim

@pruthvistony pruthvistony Awaiting requested review from pruthvistony

@stanleytsang-amd stanleytsang-amd Awaiting requested review from stanleytsang-amd stanleytsang-amd will be requested when the pull request is marked ready for review stanleytsang-amd is a code owner

@umfranzw umfranzw Awaiting requested review from umfranzw umfranzw will be requested when the pull request is marked ready for review umfranzw is a code owner

@RobsonRLemos RobsonRLemos Awaiting requested review from RobsonRLemos RobsonRLemos will be requested when the pull request is marked ready for review RobsonRLemos is a code owner

@lawruble13 lawruble13 Awaiting requested review from lawruble13 lawruble13 will be requested when the pull request is marked ready for review lawruble13 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@lawruble13 lawruble13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raramakr @lawruble13