Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix reference lib 6.1 #1407

Open
wants to merge 4 commits into
base: release/rocm-rel-6.1
Choose a base branch
from

Conversation

TorreZuk
Copy link
Contributor

  • avoids reference code rare and random host ONLY NaNs on some gemms resulting in test failures:
    Value of: rocblas_isnan(hGPU[i + idx])
    Actual: false
    Expected: true
  • no change to library

TorreZuk and others added 4 commits March 15, 2024 13:13
* move reference gemm code into functions in .cpp to compile only once
* use legacy gemm reference code for small gemm and gemm_ex to avoid random NaN issue
* Review again with later AOCL version
* use legacy reference for even larger gemms to avoid random host NaNs
reference wrappers use ref_ prefix (#2226)
* avoid name collisions with AOCL and other cblas reference functions
Copy link
Contributor

@amcamd amcamd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants