Backward compatible with version 2 decryption. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Changes since version 2, the version 3 implementation can actually be used to decrypt version 2 encrypted content. Only the caller is responsible for passing in the correct password and password length.
I made these changes based on my personal needs. My server returned version 2 encrypted data, so I need to be able to decrypt it. The differences between version 2 and version 3 can be handled automatically in other language implementations such as objc. C language version only need to let the caller handle this problem.
I am not sure if this PR needs to be merged. I am submitting this PR for those who have the same needs as me.