Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

01-ci: Update task 1 compile test #263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

01-ci: Update task 1 compile test #263

wants to merge 1 commit into from

Conversation

MrKevinWeiss
Copy link
Contributor

Nobody actually runs the compile_test.py script I hope...

@aabadie
Copy link
Contributor

aabadie commented Nov 2, 2022

Something that could also be done once the new murdock instance is in place is to modify .murdock.yml so that when a new tag is pushed a new job is launched. Since a new tag is pushed when a new RC is opened, then the compile/test task will be done automatically.

kaspar030
kaspar030 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030
Copy link
Contributor

pls rebase

@kaspar030
Copy link
Contributor

Something that could also be done once the new murdock instance is in place is to modify .murdock.yml so that when a new tag is pushed a new job is launched. Since a new tag is pushed when a new RC is opened, then the compile/test task will be done automatically.

hm, there now is always a bors full build for the branch which can be re-used. maybe just mention that?

kaspar030
kaspar030 requested changes Jan 11, 2023
View reviewed changes
01-ci/README.md Outdated Show resolved Hide resolved
@MrKevinWeiss
Copy link
Contributor Author

ping @kaspar030

@Teufelchen1
Copy link

@kaspar030 can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrKevinWeiss @aabadie @kaspar030 @Teufelchen1