Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/at86rf215: port to new netdev API #20672

Merged
merged 1 commit into from
May 15, 2024
Merged

drivers/at86rf215: port to new netdev API #20672

merged 1 commit into from
May 15, 2024

Conversation

benpicco
Copy link
Contributor

Contribution description

This allows us to get rid of the hacky blocking send.

Testing procedure

To send fragmented frames, the gnrc_netif_pktq module is now requred.

2024-05-15 17:25:45,135 # > ping -s 1024 fe80::ac8d:fee1:60ed:99c5%7
2024-05-15 17:25:45,331 # 1032 bytes from fe80::ac8d:fee1:60ed:99c5%7: icmp_seq=0 ttl=64 rssi=-45 dBm time=187.865 ms
2024-05-15 17:25:46,325 # 1032 bytes from fe80::ac8d:fee1:60ed:99c5%7: icmp_seq=1 ttl=64 rssi=-44 dBm time=181.878 ms
2024-05-15 17:25:47,331 # 1032 bytes from fe80::ac8d:fee1:60ed:99c5%7: icmp_seq=2 ttl=64 rssi=-44 dBm time=187.864 ms
2024-05-15 17:25:47,331 # 
2024-05-15 17:25:47,336 # --- fe80::ac8d:fee1:60ed:99c5%7 PING statistics ---
2024-05-15 17:25:47,340 # 3 packets transmitted, 3 packets received, 0% packet loss
2024-05-15 17:25:47,345 # round-trip min/avg/max = 181.878/185.869/187.865 ms

Issues/PRs references

@github-actions github-actions bot added the Area: drivers Area: Device drivers label May 15, 2024
@benpicco benpicco requested review from maribu, aabadie and jia200x and removed request for aabadie May 15, 2024 15:26
@benpicco benpicco added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label May 15, 2024
maribu
maribu approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks a lot cleaner now :)

@maribu maribu enabled auto-merge May 15, 2024 16:28
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 15, 2024
@riot-ci
Copy link

riot-ci commented May 15, 2024

Murdock results

✔️ PASSED

c1e79c8 drivers/at86rf215: port to new netdev API

Success Failures Total Runtime
10104 0 10105 12m:43s

Artifacts

@maribu maribu added this pull request to the merge queue May 15, 2024
Merged via the queue into RIOT-OS:master with commit de845a6 May 15, 2024
28 checks passed
@benpicco benpicco deleted the drivers/at86rf215-new_api branch May 16, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@jia200x jia200x Awaiting requested review from jia200x

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benpicco @riot-ci @maribu