Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/cortexm_common: make SVC call always available #20603

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dylad
Copy link
Member

@dylad dylad commented Apr 19, 2024

Contribution description

This PR proposes to make SVC call always available for user and thus removes the cortexm_svc pseudomodule.
SVCall is available on all ARMvx-M architecture. This exception was used before to trigger PendSV for the sheduler. Now PendSV is triggered manually and no longer require to use SVCall.
Since the feature was provided by default for all cortexm, I think it makes sense to remove the pseudomodule and to let it hardcoded in the code.

Testing procedure

CI should be happy.

Issues/PRs references

None.

@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: build system Area: Build system Area: pkg Area: External package ports Area: cpu Area: CPU/MCU ports labels Apr 19, 2024
Copy link
Contributor

@Teufelchen1 Teufelchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, didn't test it

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 15, 2024
@riot-ci
Copy link

riot-ci commented May 15, 2024

Murdock results

FAILED

acf9882 pkg/wamr: replace cortexm_svc FEATURE by arch_arm

Success Failures Total Runtime
6443 0 9734 08m:31s

Artifacts

@dylad dylad force-pushed the pr/cpu/cortexm/remove_svc_module branch 2 times, most recently from 9d087c9 to 7b79f67 Compare May 15, 2024 18:43
dylad added 3 commits May 15, 2024 20:55
Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
@dylad dylad force-pushed the pr/cpu/cortexm/remove_svc_module branch from 7b79f67 to acf9882 Compare May 15, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: cpu Area: CPU/MCU ports Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants