Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto KM Bulb, Dupe Block Removed #928

Closed
wants to merge 2 commits into from

Conversation

AstrlJelly
Copy link
Contributor

@AstrlJelly AstrlJelly commented May 12, 2024

oh ALSO PLAY ANIM BUG FIX. YAY.
all i had to do was change ["value"] to .value and ["Values"] to .Value
i just love programming sometimes 馃槂 馃槂 馃槂 馃槂

  • fixed duplicate keys being put into dynamic data, oops (there were ifs instead of else ifs)

this is for r1.1

oh ALSO THAT PLAY ANIM BUG GOT FIXED. YAY.
@minenice55
Copy link
Collaborator

is it ok if I cherry-picked some of these changes into one of my current working branches because I am also touching karate man plus I finally properly implemented HS' side of entity versioning there

@AstrlJelly
Copy link
Contributor Author

yeah, sure

@minenice55
Copy link
Collaborator

temp drafting since commits will be present in future pr

@minenice55 minenice55 marked this pull request as draft May 12, 2024 17:04
@minenice55 minenice55 self-assigned this May 12, 2024
@minenice55
Copy link
Collaborator

integrated into #929, closing

@minenice55 minenice55 closed this May 13, 2024
@github-actions github-actions bot mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants