Add a unique logo for Nightly builds #856
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Change Title Colours + Icon by Vincells
|
I don't know why it completely replaced the logo prefab >_< |
|
evaluating this and I've concluded that I'm not likely to accept this as-is as it misrepresents the goal of the experimental nightly builds (they're not some kind of special edition they're meant to represent the state of the program at any given time for testing and iteration) I'd move this feature to making the title screen itself more flexible for people to modify for their own distributions, we'll have to make exchanges on this topic on the discord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style over substance! A perfectly timed pr to not fix Nightly at all. :)
To "help a little to differentiate both versions of Heaven Studio", so we don't get mixups with accidentally using nightly features on another chart, or when watching a stream.
Based on proposition by Lovee on Discord, mockup by Koob, and icon by Vincells. The icon by Vincells is also included. Linked to other sprites in the prefab so that it's graceful enough™. I also changed the top title screen gradient and selection colours were to match the new logo.
I tested (as opposed to previous prs), and it builds. The only major issue we should have is if we ever change the logo, the branches might get weird (or this would also be a great thing to forget to revert upon release).
Drafted while Zeo improves animation.