-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(finally) Heaven Recorder Pull Request #707
base: master
Are you sure you want to change the base?
(finally) Heaven Recorder Pull Request #707
Conversation
uh it works guys!
audio cackle has been defeated!!
*Video Recording of your remixes ! (obviously) *”Beat to Beat” functionality, clip parts of your remixes and send them anywhere ! *Quality Settings, want more size? Turn it Down! Want more quality? Turn it Up! *I’m still Gold in Fortnite.
* Fixed bug where video would not export to directory * Fixed bug where recording would not end on the "End Remix" block * Fixed a bug where the SampleRate would not match the user's set SampleRate * Fixed a bug where the resolution would not match the user's set resolution * Added a feature when exporting to select the recording FPS * Added framedrop detection that exits out of the recording when there are significant lag spikes
* fix audio crunch (hopefully) this time
something that would warrant a PR more would be a recording method that doesn't just record playback from the rendertexture (a "proper" export), would that be feasible to look into cause that'd be preferrable to merge as a feature |
i'll look into it for a future version of heaven recorder, but this could be pretty nice for people who wanna record snippets or entire remixes with busting out OBS or whatever. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you got some dirty files in your commits here, make sure to rebase them out of your commits so that these large binary files aren't added to git history.
A little buggy and might possibly crash during recording.
BIG BIG BIG CHANGES so it might also break some stuff
and dont forget to add the FFmpeg legal stuff to the legal section in the credits