-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codebase migration progress from C++11 to C++17/20 #579
base: master
Are you sure you want to change the base?
Conversation
075477c
to
1f3bb26
Compare
-return std::shared_ptr<language>(new some_language(*this)); //*this is specialized language info for that lang
+return std::make_shared<language>(*this); looks like it creates the objects of superclass instead of objects of specialized classes. IDK if it is OK, but IMHO if it is, then the specialized classes should be eliminated in a separate PR. |
5cda4a0
to
a56c8fc
Compare
Windows build:
Linux build:
@KOLANICH, I thought there was support for new standard, I saw a mention here: Lines 32 to 38 in 219f846
|
hello. in cmake yes. but hour CI uses scons. since we're not using all the features of c++11 yet, I'm not sure if switching to a newer standard is a good idea. |
@alex19EP, if you set up a CI for new standard, I can do a code modernize? |
as I already said
if you want to work on it, you can do some research on cpp11 features. offhand, it seems to me that we can abandon the self-made thread class ... |
I've just thought of the limitations this may put on Linux support.
Which distros that may still be in use may not have new enough
compilers? I'm not really familiar with this. For example, will Debian
stable be OK with this? OR older Ubuntus which are still supported by
Canonical?
|
lets ask @sthibaul |
debian's default gcc will be at least gcc-12 |
debian's current stable gcc is gcc-10 |
@KOLANICH, @alex19EP review my pull request and feedback me.