Add Manipulation #7

NotMePipe · 2022-01-19T01:08:26Z

Add code for manipulating game pieces

codeclimate · 2022-01-22T14:48:34Z

src/main/java/frc/robot/Robot.java

+      System.out.println("Initializing manipulation...");
+      manipulation = new Manipulation(0, 1, 7, 8);
+    } else {
+      System.out.println("Manipulation initialization disabled.");


Replace this use of System.out or System.err by a logger.

codeclimate · 2022-01-22T14:48:34Z

src/main/java/frc/robot/Robot.java

@@ -38,6 +41,13 @@ public void robotInit() {
    driver = new LoggableController("Driver", 0);
    operator = new LoggableController("Operator", 1);

+    if (manipulationEnabled) {
+      System.out.println("Initializing manipulation...");


Replace this use of System.out or System.err by a logger.

codeclimate · 2022-01-22T14:48:34Z

src/main/java/frc/robot/Manipulation.java

+    Manipulation(int pneumaticsForwardChannel, int pneumaticsReverseChannel, int intakeWheelID, int indexLoadID) {
+        this.intakeWheel = new CANSparkMax(intakeWheelID, MotorType.kBrushless);
+        this.indexLoad = new CANSparkMax(indexLoadID, MotorType.kBrushless);
+        this.intakePneumatics = new DoubleSolenoid(PneumaticsModuleType.REVPH, pneumaticsForwardChannel, pneumaticsReverseChannel);


Line is longer than 100 characters (found 131).

codeclimate · 2022-01-22T14:48:34Z

src/main/java/frc/robot/Manipulation.java

+import edu.wpi.first.wpilibj.DoubleSolenoid.Value;
+
+import com.revrobotics.CANSparkMax;
+import com.revrobotics.CANSparkMaxLowLevel.MotorType;


Wrong lexicographical order for 'com.revrobotics.CANSparkMaxLowLevel.MotorType' import. Should be before 'edu.wpi.first.wpilibj.PneumaticsModuleType'.

codeclimate · 2022-01-22T14:48:34Z

src/main/java/frc/robot/Manipulation.java

+import com.revrobotics.CANSparkMax;
+import com.revrobotics.CANSparkMaxLowLevel.MotorType;
+
+import frc.robot.logging.Loggable;


Extra separation in import group before 'frc.robot.logging.Loggable'

codeclimate · 2022-01-22T14:48:34Z

src/main/java/frc/robot/Manipulation.java

+    private double speed;
+    private boolean spinning;
+
+    /**


First sentence of Javadoc is missing an ending period.

codeclimate · 2022-01-22T14:48:34Z

src/main/java/frc/robot/Manipulation.java

+     * @param indexLoadID The CAN id of the spark for the index loader
+     * 
+     */
+    Manipulation(int pneumaticsForwardChannel, int pneumaticsReverseChannel, int intakeWheelID, int indexLoadID) {


Line is longer than 100 characters (found 114).

codeclimate · 2022-01-22T14:48:34Z

src/main/java/frc/robot/Manipulation.java

+import edu.wpi.first.wpilibj.PneumaticsModuleType;
+import edu.wpi.first.wpilibj.DoubleSolenoid.Value;
+
+import com.revrobotics.CANSparkMax;


Wrong lexicographical order for 'com.revrobotics.CANSparkMax' import. Should be before 'edu.wpi.first.wpilibj.PneumaticsModuleType'.

codeclimate · 2022-01-22T14:48:35Z

src/main/java/frc/robot/Manipulation.java

+        .setInverted(true);
+    }
+
+    /**


First sentence of Javadoc is missing an ending period.

codeclimate · 2022-01-22T14:48:35Z

src/main/java/frc/robot/Manipulation.java

+        this.spinning = spin;
+    }
+
+    /**


First sentence of Javadoc is missing an ending period.

codeclimate · 2022-01-22T15:14:42Z

src/main/java/frc/robot/Manipulation.java

+
+import edu.wpi.first.wpilibj.DoubleSolenoid;
+import edu.wpi.first.wpilibj.PneumaticsModuleType;
+import edu.wpi.first.wpilibj.DoubleSolenoid.Value;


Wrong lexicographical order for 'edu.wpi.first.wpilibj.DoubleSolenoid.Value' import. Should be before 'edu.wpi.first.wpilibj.PneumaticsModuleType'.

codeclimate · 2022-01-22T15:14:43Z

src/main/java/frc/robot/Manipulation.java

+import edu.wpi.first.wpilibj.PneumaticsModuleType;
+import edu.wpi.first.wpilibj.DoubleSolenoid.Value;
+
+import com.revrobotics.CANSparkMax;


Extra separation in import group before 'com.revrobotics.CANSparkMax'

codeclimate · 2022-01-22T15:14:43Z

src/main/java/frc/robot/Manipulation.java

+    public void setIntakeExtend(boolean extend) {
+        intakePneumatics.set(extend ? Value.kForward : Value.kReverse);
+    }
+    /**


First sentence of Javadoc is missing an ending period.

codeclimate · 2022-01-22T15:14:43Z

src/main/java/frc/robot/Manipulation.java

+     * @param load True if it should load; false if not
+     * 
+     */
+    public void setIndexLoad(boolean load) {


'METHOD_DEF' should be separated from previous statement.

codeclimate · 2022-01-29T14:38:54Z

src/main/java/frc/robot/Manipulation.java

+     * @param load True if it should load; false if not
+     * 
+     */
+    public void setIndexLoad(boolean load) {


'METHOD_DEF' should be separated from previous line.

codecov-commenter · 2022-01-29T14:39:36Z

Codecov Report

Merging #7 (9a5c730) into master (cee37a9) will decrease coverage by 1.41%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master       #7      +/-   ##
============================================
- Coverage     17.78%   16.37%   -1.42%     
  Complexity       17       17              
============================================
  Files            13       14       +1     
  Lines           371      403      +32     
  Branches         25       29       +4     
============================================
  Hits             66       66              
- Misses          305      337      +32

Impacted Files	Coverage Δ
src/main/java/frc/robot/Manipulation.java	`0.00% <0.00%> (ø)`
src/main/java/frc/robot/Robot.java	`0.00% <0.00%> (ø)`

codeclimate · 2022-02-05T15:18:48Z

src/main/java/frc/robot/Robot.java

@@ -38,6 +41,13 @@
        driver = new LoggableController("Driver", 0);
        operator = new LoggableController("Operator", 1);

+        if (manipulationEnabled) {
+            System.out.println("Initializing manipulation...");


Replace this use of System.out or System.err by a logger.

codeclimate · 2022-02-05T15:18:48Z

src/main/java/frc/robot/Robot.java

+            System.out.println("Initializing manipulation...");
+            manipulation = new Manipulation(0, 1, 7, 8);
+        } else {
+            System.out.println("Manipulation initialization disabled.");


Replace this use of System.out or System.err by a logger.

codeclimate · 2022-02-05T15:18:48Z

src/main/java/frc/robot/Manipulation.java

+import com.revrobotics.CANSparkMax;
+import com.revrobotics.CANSparkMaxLowLevel.MotorType;
+
+import frc.robot.logging.Loggable;


Import statement for 'frc.robot.logging.Loggable' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line.

codeclimate · 2022-02-05T15:18:48Z

src/main/java/frc/robot/Manipulation.java

+import com.revrobotics.CANSparkMaxLowLevel.MotorType;
+
+import frc.robot.logging.Loggable;
+import frc.robot.logging.Logger;


Import statement for 'frc.robot.logging.Logger' is in the wrong order. Should be in the 'THIRD_PARTY_PACKAGE' group, expecting not assigned imports on this line.

codeclimate · 2022-02-18T23:38:30Z

Code Climate has analyzed commit 9a5c730 and detected 10 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	2
Style	8

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 16.3% (-1.3% change).

View more on Code Climate.

NotMePipe added 2 commits January 18, 2022 20:05

Add Manipulation.java

d6c08b4

Implement Manipulation

4163e72

NotMePipe requested a review from TheBitEffect January 19, 2022 01:08

NotMePipe added 4 commits January 18, 2022 20:49

Begin documenting Manipulation

d13ec9c

Document Manipulation methods

910d366

Remove Shoot method

8699047

Fix some errors in Robot.java

0d3f789

NotMePipe requested a review from sreeves750 January 22, 2022 01:33

Fix initialization boolean from defaulting null

f9fce03

codeclimate bot reviewed Jan 22, 2022

View reviewed changes

Fix potential intakeWheel bug

447dbcd

codeclimate bot reviewed Jan 22, 2022

View reviewed changes

NotMePipe and others added 3 commits January 22, 2022 10:41

Remove redundant if statement in teleopPeriodic

3a6203e

Merge branch 'master' into manipulation

f70bebd

Merge branch 'master' into manipulation

e24a260

codeclimate bot reviewed Jan 29, 2022

View reviewed changes

Merge branch 'master' into manipulation

1c66fd0

codeclimate bot reviewed Feb 5, 2022

View reviewed changes

TheBitEffect and others added 4 commits February 5, 2022 10:34

Merge branch 'master' into manipulation

04646a9

Merge branch 'master' into manipulation

2679dfe

Change intake speed

2491a64

Merge branch 'master' into manipulation

9a5c730

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Manipulation #7

Add Manipulation #7

NotMePipe commented Jan 19, 2022

codeclimate bot Jan 22, 2022

codeclimate bot Jan 22, 2022

codeclimate bot Jan 22, 2022

codeclimate bot Jan 22, 2022

codeclimate bot Jan 22, 2022

codeclimate bot Jan 22, 2022

codeclimate bot Jan 22, 2022

codeclimate bot Jan 22, 2022

codeclimate bot Jan 22, 2022

codeclimate bot Jan 22, 2022

codeclimate bot Jan 22, 2022

codeclimate bot Jan 22, 2022

codeclimate bot Jan 22, 2022

codeclimate bot Jan 22, 2022

codeclimate bot Jan 29, 2022

codecov-commenter commented Jan 29, 2022 •

edited by codecov bot

codeclimate bot Feb 5, 2022

codeclimate bot Feb 5, 2022

codeclimate bot Feb 5, 2022

codeclimate bot Feb 5, 2022

codeclimate bot commented Feb 18, 2022

Add Manipulation #7

Are you sure you want to change the base?

Add Manipulation #7

Conversation

NotMePipe commented Jan 19, 2022

codeclimate bot Jan 22, 2022

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2022

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2022

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2022

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2022

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2022

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2022

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2022

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2022

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2022

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2022

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2022

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2022

Choose a reason for hiding this comment

codeclimate bot Jan 22, 2022

Choose a reason for hiding this comment

codeclimate bot Jan 29, 2022

Choose a reason for hiding this comment

codecov-commenter commented Jan 29, 2022 • edited by codecov bot

Codecov Report

codeclimate bot Feb 5, 2022

Choose a reason for hiding this comment

codeclimate bot Feb 5, 2022

Choose a reason for hiding this comment

codeclimate bot Feb 5, 2022

Choose a reason for hiding this comment

codeclimate bot Feb 5, 2022

Choose a reason for hiding this comment

codeclimate bot commented Feb 18, 2022

codecov-commenter commented Jan 29, 2022 •

edited by codecov bot