Change Logger to start transition to Sendables #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
============================================
- Coverage 17.78% 16.33% -1.46%
Complexity 17 17
============================================
Files 13 13
Lines 371 404 +33
Branches 25 32 +7
============================================
Hits 66 66
- Misses 305 338 +33
|
Sent from my iPad
|
CodeClimate is just complaining about Javadoc formatting, not using an external logging library and code duplication that @tricktrap and I have decided would leave the code clearer to ignore. I will fix the Javadocs later tonight, but other than that, I do believe that this is ready for review. |
|
Code Climate has analyzed commit fbbc581 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 16.3% (-1.3% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WPILib is now including a much easier way to have classes interact with SmartDashboard. While there is no on-bot logging (yet), having WPILib handle the outputting of variables to SmartDashboard and having the ability to change values from the driver station on-the-fly might be beneficial.