Allow unsafe characters if invoked as qubes.UnsafeFileCopy #497
Conversation
DemiMarie
force-pushed
the
less-safe-unpack
branch
from
ed6aa8c
to
95a30dd
Compare
Fixes a compiler warning.
Previously various invalid arguments were silently ignored or misparsed.
According to the manual page, setfsuid() does not provide any indication of success or failure. The only way to check if it succeeded is to call it again with -1 as the UID and check the return value.
This should never happen.
No functional change.
DemiMarie
force-pushed
the
less-safe-unpack
branch
from
95a30dd
to
9d625db
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024052002-4.2&flavor=pull-requests New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024051522-4.2&flavor=update
Failed tests20 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/99767#dependencies 2 fixed
Unstable tests
|
There was a problem hiding this comment.
This PR is missing actually introducing qubes.UnsafeFilecopy service. And also changing qvm-copy to choose service based on files to be copied (see QubesOS/qubes-issues#8332 (comment))
There is no good reason not to use these flags.
This requires QubesOS/qubes-linux-utils#113. It also adds a new argument parser based on getopt_long(), which is used instead of the old hand-rolled code unless there are at least two arguments and the first one starts with an ASCII digit. Part of QubesOS/qubes-issues#8332
This is mostly identical to qubes.Filecopy, but it skips character set checking. In the future, this might be replaced by arguments to the qubes.Filecopy service, but for now, the explicit "Unsafe" in the service name is easier for users to understand.
DemiMarie
force-pushed
the
less-safe-unpack
branch
from
9d625db
to
a95d3e9
Compare
This uses QREXEC_SERVICE_FULL_NAME to detect what the service was invoked as. Non-empty arguments are reserved for future use.
This requires QubesOS/qubes-linux-utils#113.
Part of QubesOS/qubes-issues#8332