Avoid stopping qubes-network-uplink@eth0.service #442

DemiMarie · 2023-07-17T02:39:52Z

This is already started by qubes-network-uplink.service, so stopping it is a bad idea. Since setup-ip is not idempotent, the result is a down network interface.

Fixes: QubesOS/qubes-issues#8362
Fixes: QubesOS/qubes-issues#8305

This is already started by qubes-network-uplink.service, so stopping it is a bad idea. Since setup-ip is not idempotent, the result is a down network interface. Fixes: QubesOS/qubes-issues#8362 Fixes: QubesOS/qubes-issues#8305

codecov · 2023-07-17T15:17:53Z

Codecov Report

Merging #442 (5bc07d4) into main (21518b8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   70.63%   70.63%           
=======================================
  Files           3        3           
  Lines         470      470           
=======================================
  Hits          332      332           
  Misses        138      138

qubesos-bot · 2023-07-18T01:50:26Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023071717-4.2&flavor=pull-requests

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023071104-4.2&flavor=update

system_tests_network
- VmNetworking_debian-11: test_111_dynamic_detach_attach (error + cleanup)
  raise exceptions.TimeoutError() from exc... TimeoutError
- VmNetworking_debian-11: test_112_reattach_after_provider_shutdown (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmNetworking_debian-11: test_113_reattach_after_provider_kill (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmNetworking_debian-11: test_114_reattach_after_provider_crash (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmNetworking_fedora-38: test_111_dynamic_detach_attach (error + cleanup)
  raise exceptions.TimeoutError() from exc... TimeoutError
- VmNetworking_fedora-38: test_112_reattach_after_provider_shutdown (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmNetworking_fedora-38: test_113_reattach_after_provider_kill (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmNetworking_fedora-38: test_114_reattach_after_provider_crash (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
system_tests_usbproxy
- TC_20_USBProxy_core3_whonix-gw-16: test_070_attach_not_installed_front (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed: 202...
system_tests_network_ipv6
- VmIPv6Networking_debian-11: test_111_dynamic_detach_attach (error + cleanup)
  raise exceptions.TimeoutError() from exc... TimeoutError
- VmIPv6Networking_debian-11: test_112_reattach_after_provider_shutdown (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmIPv6Networking_debian-11: test_113_reattach_after_provider_kill (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmIPv6Networking_debian-11: test_114_reattach_after_provider_crash (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmIPv6Networking_fedora-38: test_111_dynamic_detach_attach (error + cleanup)
  raise exceptions.TimeoutError() from exc... TimeoutError
- VmIPv6Networking_fedora-38: test_112_reattach_after_provider_shutdown (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmIPv6Networking_fedora-38: test_113_reattach_after_provider_kill (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmIPv6Networking_fedora-38: test_114_reattach_after_provider_crash (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
system_tests_basic_vm_qrexec_gui_xfs
- TC_20_NonAudio_debian-11-pool: test_210_time_sync (error)
  subprocess.CalledProcessError: Command 'qvm-sync-clock' returned no...
system_tests_basic_vm_qrexec_gui@hw1
- TC_20_NonAudio_whonix-gw-16: test_000_start_shutdown (error + timed out)
  qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...
system_tests_kde_gui_interactive
- gui_filecopy: unnamed test (unknown)
- gui_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'disp-text-editor' mat...
system_tests_basic_vm_qrexec_gui_ext4
- switch_pool: wait_serial (wait serial expected)
  # wait_serial expected: qr/80FgT-\d+-/...
- switch_pool: Failed (test died + timed out)
  # Test died: command 'qvm-start sys-firewall sys-usb' timed out at ...
system_tests_guivm_gui_interactive
- guivm_startup: unnamed test (unknown)
- guivm_startup: Failed (test died)
  # Test died: no candidate needle with tag(s) 'desktop' matched...

Failed tests

31 failures

system_tests_network
- VmNetworking_debian-11: test_111_dynamic_detach_attach (error + cleanup)
  raise exceptions.TimeoutError() from exc... TimeoutError
- VmNetworking_debian-11: test_112_reattach_after_provider_shutdown (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmNetworking_debian-11: test_113_reattach_after_provider_kill (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmNetworking_debian-11: test_114_reattach_after_provider_crash (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- [unstable] VmNetworking_debian-11: test_203_fake_ip_inter_vm_allow (error)
  qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...
- VmNetworking_fedora-38: test_111_dynamic_detach_attach (error + cleanup)
  raise exceptions.TimeoutError() from exc... TimeoutError
- VmNetworking_fedora-38: test_112_reattach_after_provider_shutdown (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmNetworking_fedora-38: test_113_reattach_after_provider_kill (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmNetworking_fedora-38: test_114_reattach_after_provider_crash (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
system_tests_splitgpg
- TC_10_Thunderbird_whonix-ws-16: test_020_send_receive_inline_with_attachment (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- [unstable] TC_20_Evolution_debian-11: test_000_send_receive_signed_encrypted (failure)
  assert msg_body.strip() == 'This is test message'... AssertionError
system_tests_usbproxy
- TC_20_USBProxy_core3_whonix-gw-16: test_070_attach_not_installed_front (error)
  qubesusbproxy.core3ext.QubesUSBException: Device attach failed: 202...
system_tests_network_ipv6
- VmIPv6Networking_debian-11: test_111_dynamic_detach_attach (error + cleanup)
  raise exceptions.TimeoutError() from exc... TimeoutError
- VmIPv6Networking_debian-11: test_112_reattach_after_provider_shutdown (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmIPv6Networking_debian-11: test_113_reattach_after_provider_kill (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmIPv6Networking_debian-11: test_114_reattach_after_provider_crash (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmIPv6Networking_fedora-38: test_111_dynamic_detach_attach (error + cleanup)
  raise exceptions.TimeoutError() from exc... TimeoutError
- VmIPv6Networking_fedora-38: test_112_reattach_after_provider_shutdown (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmIPv6Networking_fedora-38: test_113_reattach_after_provider_kill (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- VmIPv6Networking_fedora-38: test_114_reattach_after_provider_crash (failure)
  self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
- [unstable] VmIPv6Networking_fedora-38: test_540_ipv6_inter_vm (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
system_tests_dispvm
- TC_20_DispVM_debian-11: test_030_edit_file (failure + cleanup)
  AssertionError: Timeout while waiting for disp[0-9]* window to show
- [unstable] TC_20_DispVM_debian-11: test_100_open_in_dispvm (failure)
  self.assertEqual(test_txt_content.s... AssertionError: b'' != b'test1'
system_tests_basic_vm_qrexec_gui_xfs
- TC_20_NonAudio_debian-11-pool: test_210_time_sync (error)
  subprocess.CalledProcessError: Command 'qvm-sync-clock' returned no...
system_tests_basic_vm_qrexec_gui@hw1
- TC_20_NonAudio_whonix-gw-16: test_000_start_shutdown (error + timed out)
  qubes.exc.QubesVMShutdownTimeoutError: Domain shutdown timed out: '...
system_tests_kde_gui_interactive
- gui_filecopy: unnamed test (unknown)
- gui_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'disp-text-editor' mat...
system_tests_basic_vm_qrexec_gui_ext4
- switch_pool: wait_serial (wait serial expected)
  # wait_serial expected: qr/80FgT-\d+-/...
- switch_pool: Failed (test died + timed out)
  # Test died: command 'qvm-start sys-firewall sys-usb' timed out at ...
system_tests_guivm_gui_interactive
- guivm_startup: unnamed test (unknown)
- guivm_startup: Failed (test died)
  # Test died: no candidate needle with tag(s) 'desktop' matched...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/77326#dependencies

18 fixed

system_tests_whonix
- whonixcheck: fail (unknown)
  Whonixcheck for anon-whonix failed...
- whonixcheck: unnamed test (unknown)
- whonixcheck: unnamed test (unknown)
system_tests_splitgpg
- TC_00_Direct_fedora-38: test_081_subpacket_options (error)
  qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...
system_tests_manager
- VMSettingsTest: test_26_default_dispvm (failure)
  self.assertTrue(self.vm.property_... AssertionError: False is not true
system_tests_qrexec
- TC_00_Qrexec_whonix-gw-16: test_055_qrexec_dom0_service_abort (failure)
  AssertionError: Timeout, probably stdout wasn't closed
- TC_00_Qrexec_whonix-ws-16: test_091_qrexec_service_socket_dom0_send (failure)
  AssertionError: service timeout, probably EOF wasn't transferred to...
system_tests_network_ipv6
- VmIPv6Networking_fedora-38: test_040_inter_vm (error)
  qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...
- VmIPv6Networking_fedora-38: test_203_fake_ip_inter_vm_allow (error)
  qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...
system_tests_dispvm
- TC_20_DispVM_fedora-38: test_010_simple_dvm_run (failure)
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError
- TC_20_DispVM_fedora-38: test_030_edit_file (failure + cleanup)
  AssertionError: Timeout while waiting for disp[0-9]* window to show
- TC_20_DispVM_fedora-38: test_100_open_in_dispvm (failure + cleanup)
  AssertionError: Timeout while waiting for disp[0-9]* window to show
- TC_20_DispVM_whonix-gw-16: test_010_simple_dvm_run (skipped + cleanup)
- TC_20_DispVM_whonix-gw-16: test_020_gui_app (skipped + cleanup)
- TC_20_DispVM_whonix-gw-16: test_030_edit_file (skipped + cleanup)
- TC_20_DispVM_whonix-gw-16: test_100_open_in_dispvm (skipped + cleanup)
- TC_20_DispVM_whonix-ws-16: test_010_simple_dvm_run (failure)
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError
system_tests_guivm_gui_interactive
- update_templates: Failed (test died)
  # Test died: command 'curl --form upload=@template-fedora-38-xfce-v...

Unstable tests

system_tests_whonix
whonix_torbrowser/ (2/5 times with errors)
- job 75173 None
- job 76339 None
whonix_torbrowser/ (2/5 times with errors)
- job 75173 None
- job 76339 None
whonix_torbrowser/Failed (2/5 times with errors)
- job 75173 # Test died: no candidate needle with tag(s) 'anon-whonix-tor-brows...
- job 76339 # Test died: no candidate needle with tag(s) 'anon-whonix-tor-brows...
system_tests_network
VmNetworking_debian-11/test_203_fake_ip_inter_vm_allow (4/5 times with errors)
- job 75189 qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...
- job 75362 qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...
- job 75629 qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...
- job 76757 qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...
VmNetworking_fedora-38/test_203_fake_ip_inter_vm_allow (1/5 times with errors)
- job 75362 qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...
VmNetworking_debian-11/test_210_custom_ip_simple (1/5 times with errors)
- job 75629 raise exceptions.TimeoutError() from exc... TimeoutError
system_tests_pvgrub_salt_storage
TC_10_VMSalt_fedora-38/test_000_simple_sls (3/5 times with errors)
- job 75192 import pipes...
- job 75365 import pipes...
- job 75632 import pipes...
TC_40_PVGrub_debian-11/test_000_standalone_vm (3/5 times with errors)
- job 75192 qubes.exc.QubesVMError: qrexec-daemon startup failed: 2023-06-06 06...
- job 75365 qubes.exc.QubesVMError: qrexec-daemon startup failed: 2023-06-13 05...
- job 75632 AssertionError: Failed command: apt-get update && apt-get install -...
TC_41_HVMGrub_debian-11/test_000_standalone_vm (3/5 times with errors)
- job 75192 qubes.exc.QubesVMError: qrexec-daemon startup failed: 2023-06-06 06...
- job 75365 qubes.exc.QubesVMError: qrexec-daemon startup failed: 2023-06-13 05...
- job 75632 qubes.exc.QubesVMError: qrexec-daemon startup failed: 2023-06-20 06...
TC_41_HVMGrub_fedora-38/test_000_standalone_vm (2/5 times with errors)
- job 75632 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
- job 76760 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
TC_42_PVHGrub_debian-11/test_000_standalone_vm (3/5 times with errors)
- job 75192 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
- job 75365 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
- job 75632 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
TC_10_VMSalt_fedora-38/test_001_multi_state_highstate (3/5 times with errors)
- job 75192 import pipes...
- job 75365 import pipes...
- job 75632 import pipes...
TC_10_VMSalt_fedora-38/test_003_update (3/5 times with errors)
- job 75192 import pipes...
- job 75365 import pipes...
- job 75632 import pipes...
TC_40_PVGrub_debian-11/test_010_template_based_vm (3/5 times with errors)
- job 75192 qubes.exc.QubesVMError: qrexec-daemon startup failed: 2023-06-06 06...
- job 75365 qubes.exc.QubesVMError: qrexec-daemon startup failed: 2023-06-13 05...
- job 75632 qubes.exc.QubesVMError: qrexec-daemon startup failed: 2023-06-20 06...
TC_41_HVMGrub_debian-11/test_010_template_based_vm (3/5 times with errors)
- job 75192 qubes.exc.QubesVMError: qrexec-daemon startup failed: 2023-06-06 06...
- job 75365 qubes.exc.QubesVMError: qrexec-daemon startup failed: 2023-06-13 05...
- job 75632 qubes.exc.QubesVMError: qrexec-daemon startup failed: 2023-06-20 06...
TC_42_PVHGrub_debian-11/test_010_template_based_vm (3/5 times with errors)
- job 75192 qubes.exc.QubesVMError: qrexec-daemon startup failed: 2023-06-06 06...
- job 75365 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
- job 75632 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
system_tests_splitgpg
TC_20_Evolution_debian-11/test_000_send_receive_signed_encrypted (3/5 times with errors)
- job 75194 assert msg_body.strip() == 'This is test message'... AssertionError
- job 75634 assert msg_body.strip() == 'This is test message'... AssertionError
- job 76366 assert msg_body.strip() == 'This is test message'... AssertionError
TC_10_Thunderbird_debian-11/test_020_send_receive_inline_with_attachment (1/5 times with errors)
- job 76762 assert received_attachment == orig_attachment... AssertionError
TC_10_Thunderbird_fedora-38/test_020_send_receive_inline_with_attachment (3/5 times with errors)
- job 75194 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError
- job 75367 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError
- job 76366 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError
system_tests_qrexec
TC_00_Qrexec_debian-11/test_055_qrexec_dom0_service_abort (1/5 times with errors)
- job 76761 AssertionError: Timeout, probably stdout wasn't closed
system_tests_network_ipv6
VmIPv6Networking_debian-11/test_000_simple_networking (1/5 times with errors)
- job 76758 self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0
VmIPv6Networking_debian-11/test_040_inter_vm (1/5 times with errors)
- job 76362 qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...
VmIPv6Networking_debian-11/test_203_fake_ip_inter_vm_allow (3/5 times with errors)
- job 75630 qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...
- job 76362 qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...
- job 76758 qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...
VmIPv6Networking_fedora-38/test_203_fake_ip_inter_vm_allow (2/5 times with errors)
- job 75363 qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...
- job 75630 qubes.exc.QubesMemoryError: Not enough memory to start domain 'test...
VmIPv6Networking_debian-11/test_540_ipv6_inter_vm (1/5 times with errors)
- job 76362 raise exceptions.TimeoutError() from exc... TimeoutError
VmIPv6Networking_fedora-38/test_540_ipv6_inter_vm (2/5 times with errors)
- job 75190 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
- job 75363 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
system_tests_dispvm
TC_20_DispVM_fedora-38/test_010_simple_dvm_run (4/5 times with errors)
- job 75358 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError
- job 75625 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError
- job 76357 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError
- job 76753 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError
TC_20_DispVM_whonix-gw-16/test_010_simple_dvm_run (3/5 times with errors)
- job 75358 None
- job 76753 None
- job 77349 None
TC_20_DispVM_whonix-ws-16/test_010_simple_dvm_run (3/5 times with errors)
- job 75358 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError
- job 76753 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError
- job 77349 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError
TC_20_DispVM_whonix-gw-16/test_020_gui_app (3/5 times with errors)
- job 75358 None
- job 76753 None
- job 77349 None
TC_20_DispVM_fedora-38/test_030_edit_file (4/5 times with errors)
- job 75358 AssertionError: Timeout while waiting for disp[0-9]* window to show
- job 75625 AssertionError: Timeout while waiting for disp[0-9]* window to show
- job 76753 AssertionError: Timeout while waiting for disp[0-9]* window to show
- job 77349 AssertionError: Timeout while waiting for disp[0-9]* window to show
TC_20_DispVM_whonix-gw-16/test_030_edit_file (3/5 times with errors)
- job 75358 None
- job 76753 None
- job 77349 None
TC_20_DispVM_whonix-ws-16/test_030_edit_file (2/5 times with errors)
- job 75358 AssertionError: Timeout while waiting for disp[0-9]* window to show
- job 76753 AssertionError: Timeout while waiting for disp[0-9]* window to show
TC_20_DispVM_debian-11/test_100_open_in_dispvm (5/5 times with errors)
- job 75358 AssertionError: Timeout while waiting for disp[0-9]* window to show
- job 75625 AssertionError: Timeout while waiting for disp[0-9]* window to show
- job 76357 AssertionError: Timeout while waiting for disp[0-9]* window to show
- job 76753 AssertionError: Timeout while waiting for disp[0-9]* window to show
- job 77349 self.assertEqual(test_txt_content.s... AssertionError: b'' != b'test1'
TC_20_DispVM_fedora-38/test_100_open_in_dispvm (4/5 times with errors)
- job 75358 AssertionError: Timeout while waiting for disp[0-9]* window to show
- job 76357 AssertionError: Timeout while waiting for disp[0-9]* window to show
- job 76753 AssertionError: Timeout while waiting for disp[0-9]* window to show
- job 77349 AssertionError: Timeout while waiting for disp[0-9]* window to show
TC_20_DispVM_whonix-gw-16/test_100_open_in_dispvm (3/5 times with errors)
- job 75358 None
- job 76753 None
- job 77349 None
TC_20_DispVM_whonix-ws-16/test_100_open_in_dispvm (4/5 times with errors)
- job 75358 AssertionError: Timeout while waiting for disp[0-9]* window to show
- job 75625 AssertionError: './open-file test.txt' failed with ./open-file test...
- job 76753 AssertionError: Timeout while waiting for disp[0-9]* window to show
- job 77349 AssertionError: './open-file test.txt' failed with ./open-file test...
system_tests_devices
TC_00_List_fedora-38/test_011_list_dm_mounted (1/5 times with errors)
- job 76752 AssertionError: 'test-dm' == 'test-dm' : Device test-inst-vm:dm-0 (...
system_tests_whonix@hw1
whonix_torbrowser/ (2/5 times with errors)
- job 75173 None
- job 76339 None
whonix_torbrowser/ (2/5 times with errors)
- job 75173 None
- job 76339 None
whonix_torbrowser/Failed (2/5 times with errors)
- job 75173 # Test died: no candidate needle with tag(s) 'anon-whonix-tor-brows...
- job 76339 # Test died: no candidate needle with tag(s) 'anon-whonix-tor-brows...
system_tests_basic_vm_qrexec_gui_zfs
TC_30_Gui_daemon/test_000_clipboard (1/5 times with errors)
- job 74711 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
TC_20_NonAudio_fedora-37-pool/test_100_qrexec_filecopy (1/5 times with errors)
- job 74711 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
TC_20_NonAudio_fedora-37-pool/test_105_qrexec_filemove (1/5 times with errors)
- job 74711 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
TC_20_NonAudio_fedora-37-pool/test_110_qrexec_filecopy_deny (1/5 times with errors)
- job 74711 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
TC_20_NonAudio_debian-11-pool/test_115_qrexec_filecopy_no_agent (1/5 times with errors)
- job 74711 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
TC_00_Basic/test_120_start_standalone_with_cdrom_dom0 (1/5 times with errors)
- job 74635 AssertionError: 1 != 0 : b'Timeout waiting for dom0:loop4 device to...
TC_20_NonAudio_whonix-gw-16-pool/test_130_qrexec_filemove_disk_full (1/5 times with errors)
- job 74635 subprocess.CalledProcessError: Command 'qubes.WaitForSession' retur...
TC_20_AudioVM_Pulse_debian-11-pool/test_220_audio_play_pulseaudio (1/5 times with errors)
- job 73683 AssertionError: only silence detected, no useful audio data
TC_20_AudioVM_Pulse_debian-11-pool/test_221_audio_rec_muted_pulseaudio (1/5 times with errors)
- job 73683 AssertionError: source-output for VM test-inst-vm1 not found
TC_20_AudioVM_Pulse_debian-11-pool/test_222_audio_rec_unmuted_pulseaudio (1/5 times with errors)
- job 73683 AssertionError: source-output for VM test-inst-vm1 not found
system_tests_basic_vm_qrexec_gui_btrfs
TC_20_NonAudio_whonix-gw-16-pool/test_100_qrexec_filecopy (1/5 times with errors)
- job 76764 subprocess.CalledProcessError: Command 'cp /etc/passwd /tmp/passwd'...
TC_20_AudioVM_Pulse_debian-11-pool/test_220_audio_play_pulseaudio (1/5 times with errors)
- job 73684 AssertionError: only silence detected, no useful audio data
TC_20_AudioVM_Pulse_debian-11-pool/test_221_audio_rec_muted_pulseaudio (1/5 times with errors)
- job 73684 AssertionError: source-output for VM test-inst-vm1 not found
TC_20_AudioVM_Pulse_debian-11-pool/test_222_audio_rec_unmuted_pulseaudio (1/5 times with errors)
- job 73684 AssertionError: source-output for VM test-inst-vm1 not found
system_tests_basic_vm_qrexec_gui_ext4
TC_30_Gui_daemon/test_000_clipboard (1/5 times with errors)
- job 75355 FileNotFoundError: [Errno 2] No such file or directory: '/var/run/q...
TC_20_NonAudio_whonix-ws-16-pool/test_010_run_xterm (1/5 times with errors)
- job 74643 AssertionError: Timeout while waiting for user@host window to show
TC_20_NonAudio_whonix-ws-16-pool/test_011_run_gnome_terminal (1/5 times with errors)
- job 74643 None
TC_20_AudioVM_Pulse_debian-11-pool/test_220_audio_play_pulseaudio (1/5 times with errors)
- job 73685 AssertionError: only silence detected, no useful audio data
TC_20_AudioVM_Pulse_fedora-38-pool/test_220_audio_play_pulseaudio (2/5 times with errors)
- job 75355 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
- job 76750 AssertionError: Timeout waiting for pulseaudio start in test-inst-v...
TC_20_AudioVM_Pulse_debian-11-pool/test_221_audio_rec_muted_pulseaudio (1/5 times with errors)
- job 73685 AssertionError: source-output for VM test-inst-vm1 not found
TC_20_AudioVM_Pulse_debian-11-pool/test_222_audio_rec_unmuted_pulseaudio (1/5 times with errors)
- job 73685 AssertionError: source-output for VM test-inst-vm1 not found

marmarek · 2023-07-18T02:25:21Z

VmNetworking_debian-11: test_111_dynamic_detach_attach (error + cleanup)
raise exceptions.TimeoutError() from exc... TimeoutError

VmNetworking_debian-11: test_112_reattach_after_provider_shutdown (failure)
self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0

VmNetworking_debian-11: test_113_reattach_after_provider_kill (failure)
self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0

VmNetworking_debian-11: test_114_reattach_after_provider_crash (failure)
self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0

VmNetworking_fedora-38: test_111_dynamic_detach_attach (error + cleanup)
raise exceptions.TimeoutError() from exc... TimeoutError

VmNetworking_fedora-38: test_112_reattach_after_provider_shutdown (failure)
self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0

VmNetworking_fedora-38: test_113_reattach_after_provider_kill (failure)
self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0

VmNetworking_fedora-38: test_114_reattach_after_provider_crash (failure)
self.assertEqual(self.run_cmd(self.testvm1, ... AssertionError: 2 != 0

One of those two PRs break most of dynamic network attach, my bet is on this one. My guess is: stop isn't really called, so service remain "started" and next start is a no-op? I have not checked the logs to verify that hypothesis.

Avoid stopping qubes-network-uplink@eth0.service

5bc07d4

This is already started by qubes-network-uplink.service, so stopping it is a bad idea. Since setup-ip is not idempotent, the result is a down network interface. Fixes: QubesOS/qubes-issues#8362 Fixes: QubesOS/qubes-issues#8305

marmarek added the openqa-pending label Jul 17, 2023

marmarek removed the openqa-pending label Jul 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid stopping qubes-network-uplink@eth0.service #442

Avoid stopping qubes-network-uplink@eth0.service #442

DemiMarie commented Jul 17, 2023

codecov bot commented Jul 17, 2023

qubesos-bot commented Jul 18, 2023 •

edited

marmarek commented Jul 18, 2023

Avoid stopping qubes-network-uplink@eth0.service #442

Are you sure you want to change the base?

Avoid stopping qubes-network-uplink@eth0.service #442

Conversation

DemiMarie commented Jul 17, 2023

codecov bot commented Jul 17, 2023

Codecov Report

qubesos-bot commented Jul 18, 2023 • edited

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

marmarek commented Jul 18, 2023

qubesos-bot commented Jul 18, 2023 •

edited