-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get local name from qubesdb #289
Conversation
e13cf34
to
a7517ed
Compare
ddc8e4a
to
ac97036
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
- Coverage 74.60% 74.49% -0.12%
==========================================
Files 51 51
Lines 7899 7915 +16
==========================================
+ Hits 5893 5896 +3
- Misses 2006 2019 +13 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024051221-4.2&flavor=pull-requests New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024050210-4.2&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/98585#dependencies 1 fixed
Unstable tests
|
Do not depend on hostname set inside the VM, especially since Whonix changes it. This also adds direct dependency on python3-qubesdb - previously it depended on it only indirectly (via core-agent-linux). Do include a fallback to work without qubesdb python module to allow running tests or rendering sphinx documentation without it.
ac97036
to
ba9cbf6
Compare
Do not depend on hostname set inside the VM, especially since Whonix
changes it.