new device API #274
Open
new device API #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrbartman
force-pushed
the
prb/new_device_api
branch
from
cc5a247
to
355bf81
Compare
marmarek
requested changes
Mar 15, 2024
qubesadmin/tools/qvm_device.py
Outdated
| assignment.options = options | ||
| vm.devices[args.devclass].assign(assignment) | ||
| if vm.is_running() and not assignment.attached: | ||
| print("Assigned. Now you can manually attach device or restart domain.") |
There was a problem hiding this comment.
This (and other below) should respect -q (same below).
qubesadmin/tools/qvm_device.py
Outdated
| vm.devices[args.devclass].get_assigned_devices()): | ||
| vm.devices[args.devclass].unassign(device_assignment) | ||
| if device_assignment.attached: | ||
| print("Unassigned. Now you can manually detach device " |
There was a problem hiding this comment.
This (besides -q) should also print which device.
Comment on lines
-306
to
-311
| # Special treatment for '--list-device-classes' (alias --list-classes) | ||
| curr_action = sys.argv[1:] | ||
| if set(curr_action).intersection( | ||
| {'--list-device-classes', '--list-classes'}): | ||
| sys.exit(main(args=['', '--list-device-classes'])) | ||
|
|
There was a problem hiding this comment.
What happened to this one (besides it being already slightly broken due to requiring a device class anyway)?
There was a problem hiding this comment.
I slightly fix it and now device class is not required :D (see lines 408-411).
piotrbartman
force-pushed
the
prb/new_device_api
branch
from
355bf81
to
717253f
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024052012-4.2&flavor=pull-requests New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2024051522-4.2&flavor=update
Failed tests12 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/99767#dependencies 1 fixed
Unstable tests
|
|
Starting a qube with CDROM seems to be broken: https://openqa.qubes-os.org/tests/96799#step/TC_00_Basic/4 |
|
And also, unit tests need an update (and also pylint is unhappy) |
piotrbartman
force-pushed
the
prb/new_device_api
branch
from
717253f
to
ace68ff
Compare
|
I keep device_protocol.py review in QubesOS/qubes-core-admin#579, other changes here looks okay (but I haven't tested the most recent version here yet). |
piotrbartman
force-pushed
the
prb/new_device_api
branch
from
02e9f7f
to
bc0d9bb
Compare
|
See also updated comment from the today's test run, most failures looks to be related to the devices API rework (but some are probably "just" tests to be updated). |
This is not a working API, this is just a proposal for it. references QubesOS/qubes-issues#4626
update description better error message cleanup
cleanup checking devclass
better error message update docs
fix tests minor refactor cleanup
better error message fix assignment
fix assignment
piotrbartman
force-pushed
the
prb/new_device_api
branch
from
bc0d9bb
to
a1ba96e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after QubesOS/qubes-core-admin/pull/579
Proposed device events:
sometimes event can be fired twice, we can ignore it
e.g. if device is plugged out and in in short time we can have doubled
detaching and attaching...
device-list-changed: device-added -> device-added{devclass}
device-list-changed: device-remove -> device-removed{devclass}
device-property-changed: property_name: TODO?
device-assignment-changed: created -> device-assign:{devclass}
device-assignment-changed: removed -> device-unassign:{devclass}
device-assignment-changed: attached -> device-attach:{devclass}
device-assignment-changed: detached -> device-detach:{devclass}
device-assignment-changed: property-set -> device-assignment-changed:{devclass}
QubesOS/qubes-issues#4626