Monitor and update keyboard layout only if the qube asked to be a guivm #237
Conversation
Codecov Report
@@ Coverage Diff @@
## main #237 +/- ##
==========================================
- Coverage 75.16% 75.16% -0.01%
==========================================
Files 51 51
Lines 7800 7798 -2
==========================================
- Hits 5863 5861 -2
Misses 1937 1937
|
|
I restricted a bit more the permission in my audio qube setup. ( the users comments in the qubes forum all use the "admin.vm.properties.GetAll" permission. Probably better to avoid using this one ? ). I ended up with a some of others permissions warning coming from dom0. ( Tries to access the "guivm" property and tries to access the "GetAll" property ). I ended up modifying "qvm_start_daemon" to add services check and to not use the caching system of "EventsDispatcher": From my tests the warnings disappear as I wanted but I am not sure if it is the best way of doing that. I can update the goal & code of this pull request or create a new pull request |
|
Disabling caching if it's only audiovm is probably okay, as it access much less properties. For guivm, the caching (and using GetAll) avoids several "Get" calls when starting a single qube. Your approach looks fine I think. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023041304-4.2&flavor=pull-requests New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023021823-4.2&flavor=update
Failed tests74 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/60652#dependencies 8 fixed
Unstable tests
|
This failure does mean the keyboard layout setting got broken, so something went wrong in this PR. |
goal is to avoid trying to run service X if the qubes have not be configure to run service X. It avoid useless error messages regarding mission qubes-rpm permissions
|
Some additionnal modifications:
Notes: |
|
Can I help / improve something for this pull request ? |
Before this patch, qvm_start_daemon try to read and update keyboard layout regardless if the qube is a audiovm or guivm.
With this patch it read and update keyboard layout only if the qube is a guivm.
Should fix QubesOS/qubes-issues#8109