Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.4.0] Improve mapset download #4118

Open
wants to merge 22 commits into
base: ui-redesign
Choose a base branch
from
Open

[1.4.0] Improve mapset download #4118

wants to merge 22 commits into from

Conversation

QiuFeng54321
Copy link
Contributor

@QiuFeng54321 QiuFeng54321 commented May 11, 2024 •
edited

Requires https://github.com/Quaver/Quaver.Server.Client/pull/16 and Quaver/Quaver.Resources#16

  • Adds the ability to stop, retry and remove downloads.
  • Retry only available after being stuck
  • Clear items after import
  • Fix bug: download blocking in queue (currently only checks IsDownloading but not if finished)8fa3/Quaver.Shared/Screens/Edit/Dialogs/EditorUploadingMapsetDialog.cs#L83))

It looks like this (subject to change):
image

@QiuFeng54321
Add hub download textures
fb245a8
@QiuFeng54321
Remove MultiplayerSharedMapsetDownload.Download overload because it's…
ae70d17 
… identical to its parent implementation
@QiuFeng54321
Use FileDownloader
326d015
@QiuFeng54321
Change UI of DrawableDownload
1fed4fb
@QiuFeng54321
Support variable height poolable sprite items
fed3f6f
@QiuFeng54321
Update UI textures
e0070b0
@QiuFeng54321
Reorganize items when item dimension changes
f1072bb
@QiuFeng54321
Start downloading properly
e6d7fa6
@QiuFeng54321
Fix next item download in queue
099d5e2
@QiuFeng54321
Fix eta calculation divide by zero
2d1c1e6
@QiuFeng54321
Remove download if the item is still in queue
b846cd4
@QiuFeng54321
Make ETA text more descriptive
55c3ae5
@QiuFeng54321
Make scheduling under one call only and rename EstimatedDownloadingTi…
ec1d4f0 
…me -> Title
@QiuFeng54321
Guard status changes properly and fix download queue not starting new…
1c53dbe 
… items
@QiuFeng54321
Fix inappropriate middle item index finding and handling of usePoolCount
58bf270
@QiuFeng54321
Insert new downloads to front of queue
5d8a326
@QiuFeng54321
Fix updating of title text
353df6b 
Use sliding window to reduce fluctuation of ETA
Update ETA once per second only
@QiuFeng54321
Move ETA and Retry logic to MapsetDownload
a187295 
Show retry button only if the following holds:
1. At least some time (10s) has passed since download started
2. If the map is already downloading, the ETA has to be over 30s
3. The download is not complete
@QiuFeng54321
Remove download when complete
62a0691 
Call different download function for shared mapset
@QiuFeng54321
Add documentation
d475d8e
@QiuFeng54321
Add highlighting for mapset name and artist. Truncate them properly.
73c027d
@QiuFeng54321 QiuFeng54321 marked this pull request as ready for review May 14, 2024 06:10
@AiAe AiAe changed the title Improve mapset download [1.4.0] Improve mapset download May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@QiuFeng54321