Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper support for hitsounds in plugins #4107

Open
wants to merge 3 commits into
base: ui-redesign
Choose a base branch
from

Conversation

Emik03
Copy link
Member

@Emik03 Emik03 commented May 7, 2024

  • You cannot perform the AddHitsound or RemoveHitsound action type.
  • It is impossible to get the underlying representation of HitSounds to perform arithmetic on.

This PR fixes both of those things.

@Emik03
Copy link
Member Author

Emik03 commented May 10, 2024

example plugin that needs this PR qwe.zip

untested because i can't even reproduce the build for whatever reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant