Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-35363 was closed by gh-41608 #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Jul 26, 2020

The NCCL issues we needed to patch were fixed on latest master. At some point, when all the open branches are using gh-41608, we should drop the patching code.

@pearu
Copy link
Contributor

pearu commented Aug 16, 2020

There is a reason for keeping the patches in the activate script: when doing git bisect, the earlier revisions of pytorch may require the patch.

So, I'd keep the patch in the activate script for a little while more and remove it, say, within the next 5 months when git-bisecting the relevant parts of pytorch history will be less likely needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants