substitute c++14 for c++17 with more environment variables #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pearu
requested changes
Aug 16, 2020
Comment on lines
+157
to
+159
| if [ -v CXXFLAGS_CONDA_NVCC_BACKUP ] ; then | ||
| export CXXFLAGS_CONDA_NVCC_BACKUP="`echo $CXXFLAGS_CONDA_NVCC_BACKUP | sed 's/-std=c++17/-std=c++14/'`" | ||
| fi |
There was a problem hiding this comment.
CXXFLAGS_CONDA_NVCC_BACKUP should not be changed, it is needed for deactivating the environment.
| export CXXFLAGS_USED="`echo $CXXFLAGS_USED | sed 's/-std=c++17/-std=c++14/'`" | ||
| fi | ||
| if [ -v DEBUG_CXXFLAGS ] ; then | ||
| export DEBUG_CXXFLAGS="`echo $DEBUG_CXXFLAGS | sed 's/-std=c++17/-std=c++14/'`" |
There was a problem hiding this comment.
that's ok but has a typo in sed command: it misses the tailing g
| if [ -v CXXFLAGS_CONDA_NVCC_BACKUP ] ; then | ||
| export CXXFLAGS_CONDA_NVCC_BACKUP="`echo $CXXFLAGS_CONDA_NVCC_BACKUP | sed 's/-std=c++17/-std=c++14/'`" | ||
| fi | ||
| if [ -v CXXFLAGS_USED ] ; then |
There was a problem hiding this comment.
what defines CXXFLAGS_USED? Is it used within pytorch build system?
|
I can't really answer any of the questions about these environment variables, I do not know where they came from. Feel free to close this, as it was more of a proof-of-concept of what worked for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this is overkill. At least one of these broke my environment. I don't know which one, but is sure was frustrating to dig around and find this.