Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOG] Add "Writing fast string ufuncs for NumPy 2.0" #839

Merged
merged 3 commits into from May 21, 2024

Conversation

lysnikolaou
Copy link
Contributor

Text styling

  • The blog is written with plain language (where relevant).
  • If there are headers, they use the proper header tags in order to do so (with only one level-one header).
  • All links describe where they link to (for example, check the Quansight labs website).
  • Any kind of styling that the author uses (for example, bold for emphasis) is consistent throughout the blog.

Non-text contents

  • Blog post featured image is in PNG or JPEG format, not SVG.
  • All content is represented as text (for example, images need alt text and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing gifs or videos.
  • If it were to be read as plain text, the blog still makes sense and no information is missing.

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
labs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 3:24pm

@rgommers
Copy link
Member

Thanks for writing this @lysnikolaou! @ngoldbaum would you be able to do a first pass review for this perhaps?

Copy link

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few inline comments to improve clarity but this is publishable as-is IMO.

apps/labs/posts/numpy-string-ufuncs.md Outdated Show resolved Hide resolved
apps/labs/posts/numpy-string-ufuncs.md Show resolved Hide resolved
apps/labs/posts/numpy-string-ufuncs.md Show resolved Hide resolved
apps/labs/posts/numpy-string-ufuncs.md Outdated Show resolved Hide resolved
apps/labs/public/posts/numpy-string-ufuncs/benchmarks.png Outdated Show resolved Hide resolved
@lysnikolaou
Copy link
Contributor Author

Ping. As we approach the NumPy 2.0 final release, it'd be nice to have this reviewed and ready to merge.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With NumPy 2.0 now actually close to being released, it's time to get this in. It's a really nice story @lysnikolaou. The structure is great - I only had some copy-editing comments. I'll put those in to get this merged.

apps/labs/posts/numpy-string-ufuncs.md Outdated Show resolved Hide resolved
apps/labs/posts/numpy-string-ufuncs.md Outdated Show resolved Hide resolved
apps/labs/posts/numpy-string-ufuncs.md Outdated Show resolved Hide resolved
apps/labs/posts/numpy-string-ufuncs.md Outdated Show resolved Hide resolved
apps/labs/posts/numpy-string-ufuncs.md Outdated Show resolved Hide resolved
apps/labs/posts/numpy-string-ufuncs.md Outdated Show resolved Hide resolved
apps/labs/posts/numpy-string-ufuncs.md Outdated Show resolved Hide resolved
apps/labs/posts/numpy-string-ufuncs.md Outdated Show resolved Hide resolved
apps/labs/posts/numpy-string-ufuncs.md Outdated Show resolved Hide resolved
apps/labs/posts/numpy-string-ufuncs.md Outdated Show resolved Hide resolved
@rgommers rgommers added labs 🔭 Items related to the Labs website type: content 📝 labels May 21, 2024
@rgommers rgommers merged commit f85a76d into Quansight:develop May 21, 2024
2 checks passed
@lysnikolaou
Copy link
Contributor Author

Thanks for reviewing this @rgommers!

@rgommers
Copy link
Member

My pleasure, it was a good read. And sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
labs 🔭 Items related to the Labs website type: content 📝
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants