Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Nx 15.9.1 #816

Open
wants to merge 39 commits into
base: develop
Choose a base branch
from
Open

Upgrade to Nx 15.9.1 #816

wants to merge 39 commits into from

Conversation

gabalafou
Copy link
Contributor

@gabalafou gabalafou commented Nov 30, 2023

This PR can somewhat be thought of as a re-opening of closed PR #723.

I wanted to go straight to the latest Nx version (17) but it was too much work. This will hopefully provide a stepping stone to future upgrades.

The process to create this PR looked something like:

git checkout develop
git pull
git checkout -b 15-9
nx migrate 15.9.1
git commit
npm install --force
git commit
# make some changes to package.json
git commit
npm install
git commit
# add .nx/cache to .gitignore
nx migrate --run-migrations --create-commits

Then I cherry picked a bunch of commits from #723.

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
labs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 4:07pm

@gabalafou
Copy link
Contributor Author

Note the following commands run without errors locally:

nx serve labs
nx lint labs
nx test labs

The same commands except test also worked for consulting. nx test consulting produces an error about fetch not being available globally. The error is thrown by the Apollo client constructor. It's puzzling to me because fetch has been a global in Node.js since v18.

Nonetheless, I get the same error on develop when I run nx test consulting so it shouldn't hold back this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant