Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOG] Nasa rose grant #428

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

[BLOG] Nasa rose grant #428

wants to merge 4 commits into from

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Aug 29, 2022

Text styling

  • The blog is written with plain language (where relevant).
  • If there are headers, they use the proper header tags in order to do so (with only one level-one header).
  • All links describe where they link to (for example, check the Quansight labs website).
  • Any kind of styling that the author uses (for example, bold for emphasis) is consistent throughout the blog.

Non-text contents

  • All content is represented as text (for example, images need alt text and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing gifs or videos.
  • If it were to be read as plain text, the blog still makes sense and no information is missing.

@mattip mattip requested a review from kherma as a code owner August 29, 2022 10:48
@vercel
Copy link

vercel bot commented Aug 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
consulting ✅ Ready (Inspect) Visit Preview Aug 31, 2022 at 10:07AM (UTC)
labs ✅ Ready (Inspect) Visit Preview Aug 31, 2022 at 10:07AM (UTC)

@mattip
Copy link
Contributor Author

mattip commented Aug 29, 2022

xref @rgommers

here is the preview. Previous review comments:

  • Integrating the images would be useful.
  • Another thing I can work on is adding more names of people involved and who does what - I think that is needed, and will make the story more engaging as well.

mattip and others added 4 commits August 31, 2022 04:04
Co-authored-by: Noa Tamir <6564007+noatamir@users.noreply.github.com>
Co-authored-by: Noa Tamir <6564007+noatamir@users.noreply.github.com>
@rgommers
Copy link
Member

Now we're getting somewhere. @mattip please let me know once you have pushed this as far as you can and want me to add some detail.

@mattip
Copy link
Contributor Author

mattip commented Aug 31, 2022

@rgommers go for it

@noatamir
Copy link
Contributor

noatamir commented Sep 1, 2022

I would suggest using new images, or if you have the source to save it at a higher resolution for the hero, and recrop it for the feature image. My concerns are:

  • The hero image appear pixelized on desktop
  • On mobile view the feature image (on the /blog page) is the wrong size, and it doesn't look good.

Desktop hero image

cropped feature image

@noatamir
Copy link
Contributor

noatamir commented Dec 6, 2022

@mattip @rgommers can I help move this forward? I can create new graphics for you?

@rgommers
Copy link
Member

rgommers commented Dec 6, 2022

@noatamir thanks for asking. This is blocked on my attention right now, I plan on circling back to this in January (I have a reminder in my calendar for it). No time before then. If you have time this month and can take care of having the required graphics in good shape, that would be helpful I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants