JSON-deserialization from decimal.MaxValue (as double) should not fail #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CptWesley
approved these changes
Apr 19, 2024
renzo-baasdam
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Amount.Maxis serialized to JSON, its gets the value7.922816251426434E+28. This value can not be deserialized, because of rounding/precision issues, that can be demonstrated without any JSON serialization:This code fails on the second line saying that
dblis either too big or too small.This p.r. adds some forgiveness when casting back from doubles to decimals, that prevents this issue from occurring.