Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pipeline #381

Merged
merged 26 commits into from Mar 20, 2024
Merged

Improve pipeline #381

merged 26 commits into from Mar 20, 2024

Conversation

renzo-baasdam
Copy link
Collaborator

@renzo-baasdam renzo-baasdam commented Mar 18, 2024

Working on #379.

  • Convert container to Linux
  • Sonar complains about the Java version
    Cannot recreate warning.
  • Build seems to fail due to not be able to load a dll
    Cannot recreate warning.
  • Build claims to succeeded while all tests fail
    Fixed by separating a multi line command into 3 separate steps.
  • Insight in tests is lacking (for inspiration see Buildalyzer)
    Seems to kindof work despite exceeding allowed size
    Test report summary is too big - setting 'listTests' to 'failed'

@renzo-baasdam renzo-baasdam mentioned this pull request Mar 18, 2024
4 tasks
@Corniel
Copy link
Collaborator

Corniel commented Mar 18, 2024

I added a task: convert (back) to Linux. This might include running the netstandard2.0 unit test targets as .NET 4.8 instead over 3.1 core.

@renzo-baasdam renzo-baasdam marked this pull request as ready for review March 19, 2024 21:56
@Corniel
Copy link
Collaborator

Corniel commented Mar 20, 2024

LGTM! Thanks for effort.

@Corniel Corniel merged commit 0b0bf53 into qowaiv-v7 Mar 20, 2024
3 checks passed
@Corniel Corniel deleted the improve-pipeline branch March 20, 2024 08:27
Corniel pushed a commit that referenced this pull request Mar 27, 2024
Corniel pushed a commit that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants