Skip to content

Commit

Permalink
Remove continue-on-error from test step, but stop sonarcloud even aft…
Browse files Browse the repository at this point in the history
…er failure.
  • Loading branch information
renzo-baasdam committed Mar 18, 2024
1 parent 28a7e19 commit 99bebb6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build-test.yaml
Expand Up @@ -54,7 +54,6 @@ jobs:
/d:sonar.cs.opencover.reportsPaths="**/coverage.**.opencover.xml" `
/d:sonar.cs.vstest.reportsPaths="**/*.trx"
- name: Test
continue-on-error: true
shell: powershell
run: |
dotnet test specs/Qowaiv.Specs --configuration Release `
Expand All @@ -63,6 +62,7 @@ jobs:
/p:ThresholdType=branch `
/p:CoverletOutputFormat=opencover
- name: Stop SonarCloud scanner
if: success() || failure()
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
Expand Down

0 comments on commit 99bebb6

Please sign in to comment.