Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving update_fake_backends.py from Qiskit #1262

Closed
wants to merge 2 commits into from

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Dec 6, 2023

With the transition of fake backends from Qiskit to qiskit-ibm-runtime, I'm moving some of the tools that use to be there to keep the backends up to date. This PR brings Qiskit/qiskit#8336

-----

Co-authored-by: "Lev S. Bishop" <18673315+levbishop@users.noreply.github.com>
Co-authored-by: Junye Huang <h.jun.ye@gmail.com>
Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Thomas Alexander <talexander@ibm.com>
@coveralls
Copy link

coveralls commented Dec 6, 2023

Pull Request Test Coverage Report for Build 7570043862

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.367%

Totals Coverage Status
Change from base Build 7558641268: 0.0%
Covered Lines: 2334
Relevant Lines: 5382

💛 - Coveralls

@ElePT
Copy link
Collaborator

ElePT commented Dec 6, 2023

Thanks for handling this move. I will make sure to include this tool in the fake_provider deprecations in Qiskit once this PR is merged.

@kt474
Copy link
Member

kt474 commented Jan 16, 2024

@1ucian0 Is this PR ready for review? Does it still need to be in draft mode?

@1ucian0
Copy link
Member Author

1ucian0 commented Jan 18, 2024

Some testing is still needed and, seems it is not part of the release, I was going to give another push after the release season. Do you needed sooner? I can put some time on it this week.

@kt474
Copy link
Member

kt474 commented Jan 18, 2024

Some testing is still needed and, seems it is not part of the release, I was going to give another push after the release season. Do you needed sooner? I can put some time on it this week.

Nope, no rush, thanks for the update

@kt474
Copy link
Member

kt474 commented May 6, 2024

This PR is 6 months old, is it ok to close for now and reopen if necessary?

@kt474
Copy link
Member

kt474 commented May 20, 2024

Closing, feel free to reopen

@kt474 kt474 closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants