Fix init of EstimatorV2 and SamplerV2 #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doichanj
added
stable-backport-potential
hhorii
reviewed
May 8, 2024
qiskit_aer/primitives/sampler_v2.py
Outdated
| @@ -98,6 +98,12 @@ def __init__( | |||
| self._seed = seed | |||
|
|
|||
| self._options = Options(**options) if options else Options() | |||
| if "method" not in self.options.backend_options: | |||
| method = ( | |||
| "density_matrix" if "noise_model" in self.options.backend_options else "automatic" | |||
There was a problem hiding this comment.
does this mean that noise simulation always use "density_matrix" in sampler?
qiskit_aer/primitives/sampler_v2.py
Outdated
| "density_matrix" if "noise_model" in self.options.backend_options else "automatic" | ||
| ) | ||
| ops = dict(method=method) | ||
| self.options.backend_options.update(ops) |
There was a problem hiding this comment.
self.options.backend_options.update({method: method})
may be simpler.
kevinsung
reviewed
May 16, 2024
| if "method" not in self.options.backend_options: | ||
| method = ( | ||
| "density_matrix" if "noise_model" in self.options.backend_options else "automatic" | ||
| ) |
There was a problem hiding this comment.
Why is this line necessary? Shouldn't we just let AerSimulator set the method if it's not specified? It should default to automatic, which should be smart enough to choose density_matrix if noise_model is specified.
There was a problem hiding this comment.
I removed this so now method=automatic is set by default and #2117 is fixed
Open
hhorii
approved these changes
May 24, 2024
doichanj
added a commit
to doichanj/qiskit-aer
that referenced
this pull request
May 28, 2024
* fix init of EstimatorV2 and SamplerV2 to handle method * add release note * fix from_backend and example in README * remove setting density_matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2117
Details and comments
This PR fixes init function of EstimatorV2 and SamplerV2 to store
methodoption inself.options.backend_optionsifmethodis not specified as input parameter