Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MultiStateDiscrimination output #1142

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix MultiStateDiscrimination output #1142

wants to merge 3 commits into from

Conversation

coruscating
Copy link
Collaborator

Summary

The discriminator configuration produced by MultiStateDiscrimination wasn't working with the discriminator node because its classes were integer state labels 0, 1,... instead of the expected strings "0", "1",... This PR changes the labels to strings and adds a test.

@coruscating coruscating added backport stable potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: Bugfix Include in the "Fixed" section of the changelog labels Apr 16, 2023
@coruscating coruscating added this to the Release 0.6 milestone Apr 19, 2023
@coruscating coruscating removed this from the Release 0.6 milestone Jul 10, 2023
@CLAassistant
Copy link

CLAassistant commented Jul 18, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eggerdj eggerdj Awaiting requested review from eggerdj

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport stable potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coruscating @CLAassistant