Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SC5511B driver #141

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add SC5511B driver #141

wants to merge 4 commits into from

Conversation

ttshaw1
Copy link

@ttshaw1 ttshaw1 commented Jul 18, 2022

Added driver for SignalCore SC5511B. Plenty of room for optimizations and new features but might be enough to get some other group up and running.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

Merging #141 (1da9d6a) into master (130370d) will decrease coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   18.90%   17.34%   -1.57%     
==========================================
  Files         124      125       +1     
  Lines       14935    16112    +1177     
==========================================
- Hits         2823     2794      -29     
- Misses      12112    13318    +1206     
Impacted Files Coverage Δ
...b_drivers/drivers/SignalCore/SignalCore_sc5511b.py 0.00% <ø> (ø)
...b_drivers/tests/QDevil/test_real_qdac2_ieee_std.py 33.33% <0.00%> (-9.53%) ⬇️
...ontrib_drivers/tests/QDevil/real_qdac2_fixtures.py 30.90% <0.00%> (-3.58%) ⬇️
...contrib_drivers/tests/QDevil/sim_qdac2_fixtures.py 78.78% <0.00%> (-1.22%) ⬇️
...trib_drivers/drivers/ZurichInstruments/ZIHDAWG8.py 55.33% <0.00%> (-0.88%) ⬇️
...odes_contrib_drivers/tests/test_Keysight_M3201A.py 15.22% <0.00%> (-0.76%) ⬇️
...ivers/drivers/Keysight/SD_common/memory_manager.py 79.64% <0.00%> (-0.36%) ⬇️
...contrib_drivers/drivers/ERAInstruments/erasynth.py 0.00% <0.00%> (ø)
...contrib_drivers/tests/test_rohdeschwarz_HMC804x.py 100.00% <0.00%> (ø)
...ontrib_drivers/drivers/Keysight/Keysight_E8267D.py 0.00% <0.00%> (ø)
... and 7 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tank you @ttshaw1 for the contribution!

i only changed the driver to use the instrument instance's own logger (here's a bit on how to use it https://qcodes.github.io/Qcodes/examples/logging/logging_example.html#Filtering-log-messages-by-instrument ).

it would be great to make private all the methods that are actually gets/sets of the parameters, but it's ok :)

i'll make a new release of qcodes_contrib_drivers after this PR merges so that you can install this driver as part of qcodes_contrib_drivers using pip install qcodes_contrib_drivers

@astafan8
Copy link
Contributor

astafan8 commented Jul 19, 2022

@ttshaw1 could you have a look at these typing errors https://github.com/QCoDeS/Qcodes_contrib_drivers/runs/7405036031?check_suite_focus=true ? if haven't worked with python typing and mypy before, we can do one of the following: exclude this driver from type checking alltogether, add # type: ignore to all the troubling lines, remove existing partial type annotations. I don't recommend either of these, but we have to be realistic and do what we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants