Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(context): establish steward context #56

Merged
merged 3 commits into from Oct 21, 2023
Merged

Conversation

bradcypert
Copy link
Contributor

Establish context class, migrate container out of request and into context, replace request in route handlers and middleware with ocontext

BREAKING CHANGE: Handlers now take in a context instead of a request, Container classes broken into smaller more meaningful pieces

fixes #51

Establish context class, migrate container out of request and into context, replace request in route
handlers and middleware with ocontext

BREAKING CHANGE: Handlers now take in a context instead of a request, Container classes broken into
smaller more meaningful pieces

fixes #51
@bradcypert bradcypert added the Router Affecting or involving Steward's router layer. label Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (7c6e198) 72.72% compared to head (6e411d0) 71.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   72.72%   71.68%   -1.04%     
==========================================
  Files           8        9       +1     
  Lines         209      219      +10     
==========================================
+ Hits          152      157       +5     
- Misses         57       62       +5     
Files Coverage Δ
lib/config/config_reader.dart 60.00% <100.00%> (ø)
lib/forms/forms.dart 100.00% <100.00%> (ø)
lib/router/request.dart 71.42% <100.00%> (-3.58%) ⬇️
lib/router/router.dart 91.25% <100.00%> (+0.34%) ⬆️
lib/router/static_binding.dart 66.66% <100.00%> (ø)
lib/container/container.dart 58.33% <50.00%> (ø)
lib/router/response.dart 71.11% <50.00%> (ø)
lib/app/app.dart 33.33% <33.33%> (ø)
lib/router/context.dart 37.50% <37.50%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bradcypert bradcypert merged commit e0f0782 into main Oct 21, 2023
1 of 3 checks passed
@bradcypert bradcypert deleted the steward-context branch October 21, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Router Affecting or involving Steward's router layer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate handler functions to take in a Steward context.
1 participant