Skip to content

Commit

Permalink
Merge pull request #45 from PyreStudios/contributing-updates
Browse files Browse the repository at this point in the history
minor fixes and info for contributing.md
  • Loading branch information
bradcypert committed Oct 4, 2023
2 parents 61f8180 + ba4079b commit ec6839a
Show file tree
Hide file tree
Showing 2 changed files with 75 additions and 91 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Expand Up @@ -22,7 +22,7 @@ Does something seem off? Are you seeing crashes that point to our code? Let us k

## Suggesting Enhancements

Wouldn't it be cool of Steward had an ".explode()" call that wiped your filesystem? Yeah, I didn't think so either, but that doesnt mean we don't want to read your suggestions for the library! Feel free to open an issue to talk through new features or ideas for Steward. Please __do not__ create new Pull Requests for features that havn't been discussed yet. We don't want you to spend your time implementing something that goes against what we believe Steward should be, especially if it won't get accepted.
Wouldn't it be cool of Steward had an ".explode()" call that wiped your filesystem? Yeah, I didn't think so either, but that doesnt mean we don't want to read your suggestions for the library! Feel free to open an issue to talk through new features or ideas for Steward. Please __do not__ create new Pull Requests for features that haven't been discussed yet. We don't want you to spend your time implementing something that goes against what we believe Steward should be, especially if it won't get accepted.

## Contributing to discussions on issues and pull requests

Expand All @@ -44,4 +44,4 @@ This will create a new executable in the `./bin` directory. You can then access

Steward uses tests to cover some (eventually most) of it's application behavior. Tests are vitally important as they help instill confidence in both the team of contributors as well as the community. It's important to write new tests as we add new functionality and existing tests must pass before changes can be merged in to our main branch.

Tests live in the `tests` folder and can be ran via `dart test` in the root directory.
Tests live in the `tests` folder and can be ran via `dart test` in the root directory. It's important that tests in our main branch always be passing.

0 comments on commit ec6839a

Please sign in to comment.