add a denouement call for all xhatters #354
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bknueven
reviewed
Nov 28, 2023
| @@ -350,6 +350,14 @@ def finalize(self): | |||
| for var, value in s._mpisppy_data.best_solution_cache.items(): | |||
| var.set_value(value, skip_validation=True) | |||
|
|
|||
| # xhatters that don't want the denouement should remove it from their cylinder | |||
| # (e.g. when they call vanilla) | |||
| # TBD: should this be higher in the class hierarchy? | |||
There was a problem hiding this comment.
Hmm ... seems like a can of worms. Some spokes have algorithms, which call the below code automatically.
This is probably worth sorting out for consistency.
There was a problem hiding this comment.
You have a good point. Probably the opt class should be the one calling denouement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this is a good idea (but we have a use case), and if it is, I'm not sure it is the best place in the class hierarchy