Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding python-louvain to testing infrastructure, as per issue 1626 #14

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Sep 25, 2020

As requested, this change adds the library python-louvain to the testing infrastructure to satisfy Pyomo/pyomo#1626.

@mrmundt
Copy link
Contributor Author

mrmundt commented Sep 25, 2020

@jsiirola - It looks like it failed on two Travis jobs but at a totally different point from what I messed with. @ghackebeil , I am never good at diagnosing this error - it happens at/after GSL.

@jsiirola
Copy link
Member

It looks like dockerhub no longer has python2.7 base images?

@mrmundt
Copy link
Contributor Author

mrmundt commented Sep 25, 2020

@ghackebeil
Copy link
Member

It has the base image. That confusing error you get is always after the docker build fails. It's looking for a local image with that name, which doesn't exist because the docker build failed.

@ghackebeil
Copy link
Member

It might have been just a download failure for the GSL build. I restarted the jobs. If that doesn't work, I'll see if I can reproduce locally.

@ghackebeil
Copy link
Member

I pulled python:2.7-buster locally, and went through the steps for the GSL build. This is where the failure occurred:

root@ef43008bf9bf:~# wget https://www.ampl.com/NEW/amplgsl/amplgsl.linux-intel64.zip
--2020-09-25 23:02:07--  https://www.ampl.com/NEW/amplgsl/amplgsl.linux-intel64.zip
Resolving www.ampl.com (www.ampl.com)... 70.38.71.71
Connecting to www.ampl.com (www.ampl.com)|70.38.71.71|:443... connected.
ERROR: The certificate of ‘www.ampl.com’ is not trusted.
ERROR: The certificate of ‘www.ampl.com’ has expired.

Adding --no-check-certificate gets around that. I'll try adding it to the build script. Hopefully all of the wget versions across the images accept that option.

@ghackebeil
Copy link
Member

ghackebeil commented Sep 25, 2020

Ugh, it's not going to be that easy. There are so many ./get.ASL like scripts in various projects that this is building, which are all calling wget at ampl.com. We might need to wait this one out, or maybe there's an environment variable that can be set during the build to get around the cert failure.

Another option is to just merge this, and the builds that succeed will be pushed to dockerhub, and those that fail will remain without this new package. Then we trigger master builds again at a later date.

@ghackebeil
Copy link
Member

Super evil idea, just replace /usr/bin/wget with something like

#! /bin/bash

_wget --no-check-certificate $@

I'll push that for now, and open a ticket to revert that change after the builds.

@ghackebeil
Copy link
Member

Looks like that worked. Feel free to merge, if you are comfortable with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants