Provide a compatibility option for clients with broken data set order. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I stumbled over an incorrect form data set construction order in HTMX. I made a bug report there (bigskysoftware/htmx#1686) but need a work around in the meantime. They seem to take care of ordering as long as the names are unique. This is backwards compatible to avoid downstream breakage.
ctheune
changed the title
|
Let's see if we can't work this out in the particular consumer of Peppercorn first. |
|
Yeah, absolutely. |
tseaver
added a commit
that referenced
this pull request
Apr 25, 2024
@ctheune PTAL -- this seems to cause a hang for me in the tests.
|
I'll double check this, but it will take a bit. Likely at least until end of May. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled over an incorrect form data set construction order in HTMX. I made a bug report there
(bigskysoftware/htmx#1686) but need a work around in the meantime.
They seem to take care of ordering as long as the names are unique.
This is backwards compatible to avoid downstream breakage.