fix: always cast PartialMessage(able) IDs to int #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulalaby
requested changes
Mar 21, 2024
Dorukyum
requested changes
Mar 22, 2024
Dorukyum
requested changes
Mar 22, 2024
| @@ -3189,7 +3189,7 @@ def __init__( | |||
| ): | |||
| self._state: ConnectionState = state | |||
| self._channel: Object = Object(id=id) | |||
| self.id: int = id | |||
| self.id: int = int(id) | |||
There was a problem hiding this comment.
Why not change the part where the ID is passed in with the wrong type instead?
There was a problem hiding this comment.
I suppose, but shouldn't we guarantee all IDs are int for parity with full channel objects?
There was a problem hiding this comment.
The library usually converts before passing in, so I think we should continue that
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was initially a PR to fix broken views sent in create_thread, but it turned out to be an underlying issue... once again with string IDs still being present in some areas of the library.
ForumChannel.create_threadused the raw string ID for the ViewStore key, resulting in it always failing to resolve. Instead of castinginthere, I opted to forcePartialMessageandPartialMessageableto always convert toint.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.