Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: retry http requests that fail with a 503 status #2395

Merged
merged 7 commits into from Mar 22, 2024
Merged

feat: retry http requests that fail with a 503 status #2395

merged 7 commits into from Mar 22, 2024

Conversation

D4rk-S0ul
Copy link
Contributor

@D4rk-S0ul D4rk-S0ul commented Mar 15, 2024 •
edited

Summary

Added the 503 status code to the retry-mechanism as a (temporary) solution for Discord's frequent server issues lately.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@D4rk-S0ul D4rk-S0ul requested a review from a team as a code owner March 15, 2024 17:19
@pullapprove4 pullapprove4 bot requested a review from Middledot March 15, 2024 17:19
@plun1331 plun1331 added status: awaiting review Awaiting review from a maintainer feature Implements a feature changelog needed labels Mar 18, 2024
plun1331
plun1331 previously requested changes Mar 18, 2024
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog please :)

@plun1331 plun1331 changed the title fix: Auto-Restart on 503 Status Code feat: retry http requests that fail with a 503 status Mar 18, 2024
plun1331
plun1331 reviewed Mar 19, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Dorukyum Dorukyum requested a review from Lulalaby March 21, 2024 04:55
@Lulalaby Lulalaby enabled auto-merge (squash) March 21, 2024 05:17
@Lulalaby Lulalaby requested review from Dorukyum and removed request for FrostByte266 and Middledot March 21, 2024 05:17
@Lulalaby Lulalaby merged commit 532db98 into Pycord-Development:master Mar 22, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plun1331 plun1331 plun1331 left review comments

@Lulalaby Lulalaby Lulalaby approved these changes

@JustaSqu1d JustaSqu1d JustaSqu1d approved these changes

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Assignees
No one assigned
Labels
feature Implements a feature status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@D4rk-S0ul @Lulalaby @plun1331 @JustaSqu1d