Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace deprecated pkg_resources with importlib.metadata to clear DeprecationWarning #2392

Merged
merged 6 commits into from Mar 17, 2024
Merged

fix: Replace deprecated pkg_resources with importlib.metadata to clear DeprecationWarning #2392

merged 6 commits into from Mar 17, 2024

Conversation

Revnoplex
Copy link
Contributor

@Revnoplex Revnoplex commented Mar 13, 2024 •
edited

Summary

Replaced pkg_resources with importlib.metadata as favoured here. Hence replacing get_distribution() with version().

This clears the following deprecation warning:

/home/username/pycord/venv/lib/python3.11/site-packages/discord/__main__.py:33: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Revnoplex Revnoplex requested a review from a team as a code owner March 13, 2024 13:51
@pullapprove4 pullapprove4 bot requested a review from plun1331 March 13, 2024 13:52
@Lulalaby Lulalaby enabled auto-merge (squash) March 13, 2024 14:10
Lulalaby
Lulalaby previously approved these changes Mar 13, 2024
View reviewed changes
@Lulalaby Lulalaby requested review from BobDotCom and removed request for plun1331 March 13, 2024 14:10
@plun1331
Copy link
Member

Should we have a changelog entry for this?

@JustaSqu1d
Copy link
Member

Should we have a changelog entry for this?

I don't think so because it doesn't affect the end-user?

@plun1331
Copy link
Member

Should we have a changelog entry for this?

I don't think so because it doesn't affect the end-user?

It removes a deprecation warning that appears in their terminal

JustaSqu1d
JustaSqu1d suggested changes Mar 15, 2024
View reviewed changes
Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry

@Revnoplex
Copy link
Contributor Author

alr, I'll get onto it soon

auto-merge was automatically disabled March 15, 2024 07:43

Head branch was pushed to by a user without write access

@Revnoplex
Copy link
Contributor Author

Done

Lulalaby
Lulalaby reviewed Mar 15, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Lulalaby
Update CHANGELOG.md
b3050f0 
Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
plun1331
plun1331 previously approved these changes Mar 15, 2024
View reviewed changes
@plun1331 plun1331 enabled auto-merge (squash) March 15, 2024 14:52
@plun1331 plun1331 added status: awaiting review Awaiting review from a maintainer and removed PA: All Contributors pending labels Mar 15, 2024
@plun1331 plun1331 added this to the v2.6 milestone Mar 15, 2024
JustaSqu1d
JustaSqu1d suggested changes Mar 15, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
auto-merge was automatically disabled March 16, 2024 00:17

Head branch was pushed to by a user without write access

@Revnoplex @JustaSqu1d
Update CHANGELOG.md
8906465 
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Signed-off-by: Revnoplex <62947003+Revnoplex@users.noreply.github.com>
@plun1331 plun1331 enabled auto-merge (squash) March 16, 2024 03:45
@Lulalaby Lulalaby disabled auto-merge March 17, 2024 01:55
@Lulalaby Lulalaby merged commit 0c68e5f into Pycord-Development:master Mar 17, 2024
31 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@plun1331 plun1331 plun1331 approved these changes

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

Assignees
No one assigned
Labels
status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Revnoplex @plun1331 @JustaSqu1d @Lulalaby