Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Proper type-hinting & docstring of Member.move_to and Member.edit #2386

Merged
merged 9 commits into from Mar 8, 2024
Merged

fix: Proper type-hinting & docstring of Member.move_to and Member.edit #2386

merged 9 commits into from Mar 8, 2024

Conversation

yoggys
Copy link
Contributor

@yoggys yoggys commented Mar 7, 2024 •
edited

Summary

Fixed type-hinting and docstring for Member.move_to as channel is excepted to be channel: Optional[:class:VoiceChannel] and Member.edit.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@yoggys yoggys requested a review from a team as a code owner March 7, 2024 23:52
@pullapprove4 pullapprove4 bot requested a review from BobDotCom March 7, 2024 23:52
Lulalaby
Lulalaby reviewed Mar 8, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Lulalaby
Update CHANGELOG.md
fff907d 
Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
Lulalaby
Lulalaby previously approved these changes Mar 8, 2024
View reviewed changes
@Lulalaby Lulalaby enabled auto-merge (squash) March 8, 2024 00:00
@Lulalaby
add pr
2e1bbfd 
Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
Lulalaby
Lulalaby previously approved these changes Mar 8, 2024
View reviewed changes
plun1331
plun1331 previously requested changes Mar 8, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@plun1331
Update CHANGELOG.md
6590db6 
Signed-off-by: plun1331 <plun1331@gmail.com>
plun1331
plun1331 reviewed Mar 8, 2024
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a chance we could also update the docstring? Stage channels also exist, not just voice

auto-merge was automatically disabled March 8, 2024 19:24

Head branch was pushed to by a user without write access

yoggys and others added 2 commits March 8, 2024 20:25
@yoggys
Copy link
Contributor Author

yoggys commented Mar 8, 2024 •
edited

@plun1331 I've also updated Member.edit docstring

@yoggys yoggys requested review from plun1331 and Lulalaby March 8, 2024 19:25
@yoggys yoggys changed the title fix: Proper type-hinting of Member.move_to fix: Proper type-hinting & docstring of Member.move_to and Member.edit Mar 8, 2024
Lulalaby
Lulalaby previously approved these changes Mar 8, 2024
View reviewed changes
@Lulalaby Lulalaby removed the request for review from plun1331 March 8, 2024 19:36
@Lulalaby Lulalaby enabled auto-merge (squash) March 8, 2024 19:37
auto-merge was automatically disabled March 8, 2024 20:44

Head branch was pushed to by a user without write access

@yoggys yoggys requested review from plun1331 and Lulalaby March 8, 2024 20:44
@yoggys
Copy link
Contributor Author

yoggys commented Mar 8, 2024 •
edited

that should be all related to StageChannel, i've also noticed one typing improvement in afk_channel as it is always VoiceChannel

@Lulalaby Lulalaby enabled auto-merge (squash) March 8, 2024 20:49
@Lulalaby Lulalaby merged commit d6693d3 into Pycord-Development:master Mar 8, 2024
31 of 54 checks passed
@yoggys yoggys deleted the move_to_typing branch March 8, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@JustaSqu1d JustaSqu1d JustaSqu1d approved these changes

@plun1331 plun1331 Awaiting requested review from plun1331

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yoggys @Lulalaby @plun1331 @JustaSqu1d